2015-06-16 07:10:05

by Abdul, Hussain (H.)

Subject: [PATCH] Staging: wilc1000: Remove casting the values returned by kmalloc()

From: Abdul Hussain <[email protected]>

This patch removes casting the values returned by memory allocation functions.

Signed-off-by: Abdul Hussain <[email protected]>
---
drivers/staging/wilc1000/linux_mon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c
index d5860ce..8cba13c 100644
--- a/drivers/staging/wilc1000/linux_mon.c
+++ b/drivers/staging/wilc1000/linux_mon.c
@@ -247,7 +247,7 @@ static int mon_mgmt_tx(struct net_device *dev, const u8 *buf, size_t len)
nic = netdev_priv(dev);

netif_stop_queue(dev);
- mgmt_tx = (struct tx_complete_mon_data *)kmalloc(sizeof(struct tx_complete_mon_data), GFP_ATOMIC);
+ mgmt_tx = kmalloc(sizeof(struct tx_complete_mon_data), GFP_ATOMIC);
if (mgmt_tx == NULL) {
PRINT_ER("Failed to allocate memory for mgmt_tx structure\n");
return WILC_FAIL;
@@ -258,7 +258,7 @@ static int mon_mgmt_tx(struct net_device *dev, const u8 *buf, size_t len)
len += sizeof(struct tx_complete_mon_data *);
#endif

- mgmt_tx->buff = (char *)kmalloc(len, GFP_ATOMIC);
+ mgmt_tx->buff = kmalloc(len, GFP_ATOMIC);
if (mgmt_tx->buff == NULL) {
PRINT_ER("Failed to allocate memory for mgmt_tx buff\n");
return WILC_FAIL;
--
1.9.1

2015-06-17 02:18:52

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: wilc1000: Remove casting the values returned by kmalloc()

On Tue, Jun 16, 2015 at 07:09:56AM +0000, Abdul, Hussain (H.) wrote:
> From: Abdul Hussain <[email protected]>
>
> This patch removes casting the values returned by memory allocation functions.
>
> Signed-off-by: Abdul Hussain <[email protected]>
> ---
> drivers/staging/wilc1000/linux_mon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Does not apply :(