2015-06-17 12:31:57

by Sunil Shahu

Subject: [PATCH] staging: media: lirc: fix coding style error

Fix code indentation error by replacing tab in place of spaces.

Signed-off-by: Sunil Shahu <[email protected]>
---
drivers/staging/media/lirc/lirc_sasem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
index 8ebee96..12aae72 100644
--- a/drivers/staging/media/lirc/lirc_sasem.c
+++ b/drivers/staging/media/lirc/lirc_sasem.c
@@ -185,7 +185,7 @@ static void deregister_from_lirc(struct sasem_context *context)
__func__, retval);
else
dev_info(&context->dev->dev,
- "Deregistered Sasem driver (minor:%d)\n", minor);
+ "Deregistered Sasem driver (minor:%d)\n", minor);

}

--
1.9.1

2015-06-19 08:03:13

by Dan Carpenter

Subject: Re: [PATCH] staging: media: lirc: fix coding style error

On Wed, Jun 17, 2015 at 06:01:32PM +0530, Sunil Shahu wrote:
> Fix code indentation error by replacing tab in place of spaces.
>
> Signed-off-by: Sunil Shahu <[email protected]>
> ---
> drivers/staging/media/lirc/lirc_sasem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
> index 8ebee96..12aae72 100644
> --- a/drivers/staging/media/lirc/lirc_sasem.c
> +++ b/drivers/staging/media/lirc/lirc_sasem.c
> @@ -185,7 +185,7 @@ static void deregister_from_lirc(struct sasem_context *context)
> __func__, retval);
> else
> dev_info(&context->dev->dev,
> - "Deregistered Sasem driver (minor:%d)\n", minor);
> + "Deregistered Sasem driver (minor:%d)\n", minor);

Not quite. The original is:

[tab][tab][space][space][space][space][space][space][space][space][space]"Dere...

You have:

[tab][tab][tab]"Deregistered Sasem driver ...

It should be:

[tab][tab][tab][space]"Deregistered Sasem driver (minor:%d)\n", minor);

regards,
dan carpenter

2015-06-19 08:42:48

by Sunil Shahu

Subject: [PATCH] staging: media: lirc: fix coding style error

Fix code indentation error by replacing tab in place of spaces.

Signed-off-by: Sunil Shahu <[email protected]>
---
drivers/staging/media/lirc/lirc_sasem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
index 8ebee96..12aae72 100644
--- a/drivers/staging/media/lirc/lirc_sasem.c
+++ b/drivers/staging/media/lirc/lirc_sasem.c
@@ -185,7 +185,7 @@ static void deregister_from_lirc(struct sasem_context *context)
__func__, retval);
else
dev_info(&context->dev->dev,
- "Deregistered Sasem driver (minor:%d)\n", minor);
+ "Deregistered Sasem driver (minor:%d)\n", minor);

}

--
1.9.1

2015-06-19 08:52:10

by Sunil Shahu

Subject: [PATCH] staging: media: lirc: fix coding style error

Fix code indentation error by replacing tab in place of spaces.

Signed-off-by: Sunil Shahu <[email protected]>
---
drivers/staging/media/lirc/lirc_sasem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
index 8ebee96..c14ca7e 100644
--- a/drivers/staging/media/lirc/lirc_sasem.c
+++ b/drivers/staging/media/lirc/lirc_sasem.c
@@ -185,7 +185,7 @@ static void deregister_from_lirc(struct sasem_context *context)
__func__, retval);
else
dev_info(&context->dev->dev,
- "Deregistered Sasem driver (minor:%d)\n", minor);
+ "Deregistered Sasem driver (minor:%d)\n", minor);

}

--
1.9.1

2015-06-19 14:06:04

by Sudip Mukherjee

Subject: Re: [PATCH] staging: media: lirc: fix coding style error

On Fri, Jun 19, 2015 at 02:22:02PM +0530, Sunil Shahu wrote:
> Fix code indentation error by replacing tab in place of spaces.
>
> Signed-off-by: Sunil Shahu <[email protected]>
when you are sending a modified patch, please mark it as [PATCH v2]
otherwise it becomes confusing.

regards
sudip

2015-06-20 08:54:15

by Sunil Shahu

Subject: [PATCH v2] staging: media: lirc: fix coding style error

Fix code indentation error by replacing tab in place of spaces.

Signed-off-by: Sunil Shahu <[email protected]>
---
drivers/staging/media/lirc/lirc_sasem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
index 8ebee96..c14ca7e 100644
--- a/drivers/staging/media/lirc/lirc_sasem.c
+++ b/drivers/staging/media/lirc/lirc_sasem.c
@@ -185,7 +185,7 @@ static void deregister_from_lirc(struct sasem_context *context)
__func__, retval);
else
dev_info(&context->dev->dev,
- "Deregistered Sasem driver (minor:%d)\n", minor);
+ "Deregistered Sasem driver (minor:%d)\n", minor);

}

--
1.7.9.5


---
This email has been checked for viruses by Avast antivirus software.
http://www.avast.com