2015-06-19 15:12:57

by Fabio Falzoi

Subject: [PATCH] Staging: rts5208: fix CHANGE_LINK_STATE value

Fix CHANGE_LINK_STATE value when card_exist is true.
This bug was introduced in a9b693cd77d70fb93dad8cbce667a49cd9b87352

Signed-off-by: Fabio Falzoi <[email protected]>
---
drivers/staging/rts5208/rtsx_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c
index d6fb6cd..0df3b9d 100644
--- a/drivers/staging/rts5208/rtsx_chip.c
+++ b/drivers/staging/rts5208/rtsx_chip.c
@@ -1337,7 +1337,7 @@ static void rtsx_delink_stage1(struct rtsx_chip *chip, int enter_L1,
rtsx_write_register(chip, HOST_SLEEP_STATE, 0x03, 1);

if (chip->card_exist)
- val = 0x03;
+ val = 0x02;
else
val = 0x0A;

--
1.9.1

2015-06-19 15:17:56

by Joe Perches

Subject: Re: [PATCH] Staging: rts5208: fix CHANGE_LINK_STATE value

On Fri, 2015-06-19 at 17:12 +0200, Fabio Falzoi wrote:
> Fix CHANGE_LINK_STATE value when card_exist is true.
> This bug was introduced in a9b693cd77d70fb93dad8cbce667a49cd9b87352

Please use just 12 byte of the SHA-1 and add the title:

Something like:

This bug was introduced in commit a9b693cd77d7 ("Staging:
rts5208: helper function to manage delink states")

Maybe add a "Fixes: " line instead.

2015-06-19 15:44:57

by Fabio Falzoi

Subject: [PATCH v2] Staging: rts5208: fix CHANGE_LINK_STATE value

Fix CHANGE_LINK_STATE value when card_exist is true.

Fixes: a9b693cd77d7 ("Staging: rts5208: helper function to manage delink states")
Signed-off-by: Fabio Falzoi <[email protected]>
---
drivers/staging/rts5208/rtsx_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c
index d6fb6cd..0df3b9d 100644
--- a/drivers/staging/rts5208/rtsx_chip.c
+++ b/drivers/staging/rts5208/rtsx_chip.c
@@ -1337,7 +1337,7 @@ static void rtsx_delink_stage1(struct rtsx_chip *chip, int enter_L1,
rtsx_write_register(chip, HOST_SLEEP_STATE, 0x03, 1);

if (chip->card_exist)
- val = 0x03;
+ val = 0x02;
else
val = 0x0A;

--
1.9.1