2015-06-20 19:06:31

by Joseph Kogut

[permalink] [raw]
Subject: [PATCH] staging: i2o: iop.c: Fix pointer declarations

Kernel coding style dictates that pointer declarations
have the asterisk next to the data name.

Signed-off-by: Joseph Kogut <[email protected]>
---
drivers/staging/i2o/iop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/i2o/iop.c b/drivers/staging/i2o/iop.c
index 23bdbe4..262d5b5 100644
--- a/drivers/staging/i2o/iop.c
+++ b/drivers/staging/i2o/iop.c
@@ -89,7 +89,7 @@ struct i2o_message *i2o_msg_get_wait(struct i2o_controller *c, int wait)
*
* Returns context id > 0 on success or 0 on failure.
*/
-u32 i2o_cntxt_list_add(struct i2o_controller * c, void *ptr)
+u32 i2o_cntxt_list_add(struct i2o_controller *c, void *ptr)
{
struct i2o_context_list_element *entry;
unsigned long flags;
@@ -135,7 +135,7 @@ u32 i2o_cntxt_list_add(struct i2o_controller * c, void *ptr)
*
* Returns context id on success or 0 on failure.
*/
-u32 i2o_cntxt_list_remove(struct i2o_controller * c, void *ptr)
+u32 i2o_cntxt_list_remove(struct i2o_controller *c, void *ptr)
{
struct i2o_context_list_element *entry;
u32 context = 0;
@@ -202,7 +202,7 @@ void *i2o_cntxt_list_get(struct i2o_controller *c, u32 context)
* Returns context id which matches to the pointer on success or 0 on
* failure.
*/
-u32 i2o_cntxt_list_get_ptr(struct i2o_controller * c, void *ptr)
+u32 i2o_cntxt_list_get_ptr(struct i2o_controller *c, void *ptr)
{
struct i2o_context_list_element *entry;
u32 context = 0;
--
2.4.4


2015-06-22 11:01:35

by Sudip Mukherjee

[permalink] [raw]
Subject: Re: [PATCH] staging: i2o: iop.c: Fix pointer declarations

On Sat, Jun 20, 2015 at 12:06:16PM -0700, Joseph Kogut wrote:
> Kernel coding style dictates that pointer declarations
> have the asterisk next to the data name.
>
> Signed-off-by: Joseph Kogut <[email protected]>
> ---
> drivers/staging/i2o/iop.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
i2o has been removed from staging. Please update your tree.

regards
sudip