2015-06-19 11:31:43

by Masahiro Yamada

Subject: [PATCH 1/2] gpio: altera: kill bogus dependency on GPIO_GENERIC

The driver gpio-altera.c does not depend on gpio-generic.c at all.
Drop unneeded "select GPIO_GENERIC".

Signed-off-by: Masahiro Yamada <[email protected]>
---

drivers/gpio/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index caefe80..25c232e 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -113,7 +113,6 @@ config GPIO_74XX_MMIO
config GPIO_ALTERA
tristate "Altera GPIO"
depends on OF_GPIO
- select GPIO_GENERIC
select GPIOLIB_IRQCHIP
help
Say Y or M here to build support for the Altera PIO device.
--
1.9.1

2015-06-19 11:31:36

by Masahiro Yamada

Subject: [PATCH 2/2] gpio: mvebu: kill bogus dependency on GPIO_GENERIC

The driver gpio-mvebu.c does not depend on gpio-generic.c at all.
Drop unneeded "select GPIO_GENERIC".

Signed-off-by: Masahiro Yamada <[email protected]>
---

drivers/gpio/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 25c232e..241d441 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -283,7 +283,6 @@ config GPIO_MVEBU
def_bool y
depends on PLAT_ORION
depends on OF
- select GPIO_GENERIC
select GENERIC_IRQ_CHIP

config GPIO_MXC
--
1.9.1

2015-06-20 23:48:26

by Masahiro Yamada

Subject: Re: [PATCH 1/2] gpio: altera: kill bogus dependency on GPIO_GENERIC

Adding Tien.


2015-06-19 20:31 GMT+09:00 Masahiro Yamada <[email protected]>:
> The driver gpio-altera.c does not depend on gpio-generic.c at all.
> Drop unneeded "select GPIO_GENERIC".
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> drivers/gpio/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index caefe80..25c232e 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -113,7 +113,6 @@ config GPIO_74XX_MMIO
> config GPIO_ALTERA
> tristate "Altera GPIO"
> depends on OF_GPIO
> - select GPIO_GENERIC
> select GPIOLIB_IRQCHIP
> help
> Say Y or M here to build support for the Altera PIO device.
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> Please read the FAQ at http://www.tux.org/lkml/



--
Best Regards
Masahiro Yamada

2015-06-20 23:55:09

by Masahiro Yamada

Subject: Re: [PATCH 2/2] gpio: mvebu: kill bogus dependency on GPIO_GENERIC

Adding more people.

I'd like them to check if this patch is correct.


2015-06-19 20:31 GMT+09:00 Masahiro Yamada <[email protected]>:
> The driver gpio-mvebu.c does not depend on gpio-generic.c at all.
> Drop unneeded "select GPIO_GENERIC".
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> drivers/gpio/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 25c232e..241d441 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -283,7 +283,6 @@ config GPIO_MVEBU
> def_bool y
> depends on PLAT_ORION
> depends on OF
> - select GPIO_GENERIC
> select GENERIC_IRQ_CHIP
>
> config GPIO_MXC
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> Please read the FAQ at http://www.tux.org/lkml/



--
Best Regards
Masahiro Yamada

2015-06-26 03:49:43

by Tien Hock Loh

Subject: Re: [PATCH 1/2] gpio: altera: kill bogus dependency on GPIO_GENERIC

Acked-by: Tien Hock Loh <[email protected]>

On Sun, 2015-06-21 at 08:48 +0900, Masahiro Yamada wrote:
> Adding Tien.
>
>
> 2015-06-19 20:31 GMT+09:00 Masahiro Yamada <[email protected]>:
> > The driver gpio-altera.c does not depend on gpio-generic.c at all.
> > Drop unneeded "select GPIO_GENERIC".
> >
> > Signed-off-by: Masahiro Yamada <[email protected]>
> > ---
> >
> > drivers/gpio/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> > index caefe80..25c232e 100644
> > --- a/drivers/gpio/Kconfig
> > +++ b/drivers/gpio/Kconfig
> > @@ -113,7 +113,6 @@ config GPIO_74XX_MMIO
> > config GPIO_ALTERA
> > tristate "Altera GPIO"
> > depends on OF_GPIO
> > - select GPIO_GENERIC
> > select GPIOLIB_IRQCHIP
> > help
> > Say Y or M here to build support for the Altera PIO device.
> > --
> > 1.9.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > Please read the FAQ at http://www.tux.org/lkml/
>
>
>

2015-06-29 12:26:06

by Gregory CLEMENT

Subject: Re: [PATCH 2/2] gpio: mvebu: kill bogus dependency on GPIO_GENERIC

Hi Masahiro,

On 21/06/2015 01:54, Masahiro Yamada wrote:
> Adding more people.
>
> I'd like them to check if this patch is correct.
>
>
> 2015-06-19 20:31 GMT+09:00 Masahiro Yamada <[email protected]>:
>> The driver gpio-mvebu.c does not depend on gpio-generic.c at all.
>> Drop unneeded "select GPIO_GENERIC".
>>
>> Signed-off-by: Masahiro Yamada <[email protected]>

This would have come from a wrong copy and paste, because indeed we
have never used the gpio-generic.

Acked-by: Gregory CLEMENT <[email protected]>


Thanks,

Gregory

>> ---
>>
>> drivers/gpio/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>> index 25c232e..241d441 100644
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -283,7 +283,6 @@ config GPIO_MVEBU
>> def_bool y
>> depends on PLAT_ORION
>> depends on OF
>> - select GPIO_GENERIC
>> select GENERIC_IRQ_CHIP
>>
>> config GPIO_MXC
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> Please read the FAQ at http://www.tux.org/lkml/
>
>
>


--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

2015-07-15 08:26:09

by Linus Walleij

Subject: Re: [PATCH 1/2] gpio: altera: kill bogus dependency on GPIO_GENERIC

On Fri, Jun 19, 2015 at 1:31 PM, Masahiro Yamada
<[email protected]> wrote:

> The driver gpio-altera.c does not depend on gpio-generic.c at all.
> Drop unneeded "select GPIO_GENERIC".
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Patch applied.

Yours,
Linus Walleij

2015-07-15 09:47:10

by Linus Walleij

Subject: Re: [PATCH 2/2] gpio: mvebu: kill bogus dependency on GPIO_GENERIC

On Fri, Jun 19, 2015 at 1:31 PM, Masahiro Yamada
<[email protected]> wrote:

> The driver gpio-mvebu.c does not depend on gpio-generic.c at all.
> Drop unneeded "select GPIO_GENERIC".
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Patch applied with Gregory's ACK.

Yours,
Linus Walleij