2015-06-26 06:25:49

by Maninder Singh

Subject: [PATCH 1/1] gpu/drm: use kzalloc for allocating one thing

Use kzalloc rather than kcalloc(1.. for allocating
one thing.

Signed-off-by: Maninder Singh <[email protected]>
Reviewed-by: Vaneet Narang <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index d3706a4..dd3415d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -674,7 +674,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_tt *ttm)
return 0;

if (gtt && gtt->userptr) {
- ttm->sg = kcalloc(1, sizeof(struct sg_table), GFP_KERNEL);
+ ttm->sg = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
if (!ttm->sg)
return -ENOMEM;

--
1.7.9.5

2015-06-26 07:31:57

by Daniel Vetter

Subject: Re: [PATCH 1/1] gpu/drm: use kzalloc for allocating one thing

On Fri, Jun 26, 2015 at 11:54:10AM +0530, Maninder Singh wrote:
> Use kzalloc rather than kcalloc(1.. for allocating
> one thing.
>
> Signed-off-by: Maninder Singh <[email protected]>
> Reviewed-by: Vaneet Narang <[email protected]>

Applied to drm-misc, thanks.
-Daniel

> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index d3706a4..dd3415d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -674,7 +674,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_tt *ttm)
> return 0;
>
> if (gtt && gtt->userptr) {
> - ttm->sg = kcalloc(1, sizeof(struct sg_table), GFP_KERNEL);
> + ttm->sg = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
> if (!ttm->sg)
> return -ENOMEM;
>
> --
> 1.7.9.5
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2015-06-26 07:34:38

by Daniel Vetter

Subject: Re: [PATCH 1/1] gpu/drm: use kzalloc for allocating one thing

On Fri, Jun 26, 2015 at 09:34:43AM +0200, Daniel Vetter wrote:
> On Fri, Jun 26, 2015 at 11:54:10AM +0530, Maninder Singh wrote:
> > Use kzalloc rather than kcalloc(1.. for allocating
> > one thing.
> >
> > Signed-off-by: Maninder Singh <[email protected]>
> > Reviewed-by: Vaneet Narang <[email protected]>
>
> Applied to drm-misc, thanks.

And dropped again since I didn't realize this is for amdgpu and not core
drm.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2015-06-26 07:41:31

by Christian König

Subject: Re: [PATCH 1/1] gpu/drm: use kzalloc for allocating one thing

On 26.06.2015 09:37, Daniel Vetter wrote:
> On Fri, Jun 26, 2015 at 09:34:43AM +0200, Daniel Vetter wrote:
>> On Fri, Jun 26, 2015 at 11:54:10AM +0530, Maninder Singh wrote:
>>> Use kzalloc rather than kcalloc(1.. for allocating
>>> one thing.
>>>
>>> Signed-off-by: Maninder Singh <[email protected]>
>>> Reviewed-by: Vaneet Narang <[email protected]>
>> Applied to drm-misc, thanks.
> And dropped again since I didn't realize this is for amdgpu and not core
> drm.

I was just about to complain on the confusing patch subject :)

So please fix the subject lines of both your patches to something like
"drm/amdgpu:" and send them out again.

With that fixed both patches are Reviewed-by: Christian K?nig
<[email protected]>

Regards,
Christian.

> -Daniel