2015-06-26 07:59:30

by Maninder Singh

Subject: [PATCH v2] drm/amdgpu: remove unnecessary check before kfree

kfree(NULL) is safe and this check is probably not required

Signed-off-by: Maninder Singh <[email protected]>
Reviewed-by: Vaneet Narang <[email protected]>
Reviewed-by: Christian Konig <[email protected]>
---
v2: Chnged shortlog prefix - gpu/amdgpu

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index fec487d..a85cd08 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1575,8 +1575,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev)
amdgpu_fence_driver_fini(adev);
amdgpu_fbdev_fini(adev);
r = amdgpu_fini(adev);
- if (adev->ip_block_enabled)
- kfree(adev->ip_block_enabled);
+ kfree(adev->ip_block_enabled);
adev->ip_block_enabled = NULL;
adev->accel_working = false;
/* free i2c buses */
--
1.7.9.5

2015-06-26 17:01:26

by Alex Deucher

Subject: Re: [PATCH v2] drm/amdgpu: remove unnecessary check before kfree

On Fri, Jun 26, 2015 at 3:56 AM, Maninder Singh <[email protected]> wrote:
> kfree(NULL) is safe and this check is probably not required
>
> Signed-off-by: Maninder Singh <[email protected]>
> Reviewed-by: Vaneet Narang <[email protected]>
> Reviewed-by: Christian Konig <[email protected]>

Applied. thanks!

Alex

> ---
> v2: Chnged shortlog prefix - gpu/amdgpu
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index fec487d..a85cd08 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1575,8 +1575,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev)
> amdgpu_fence_driver_fini(adev);
> amdgpu_fbdev_fini(adev);
> r = amdgpu_fini(adev);
> - if (adev->ip_block_enabled)
> - kfree(adev->ip_block_enabled);
> + kfree(adev->ip_block_enabled);
> adev->ip_block_enabled = NULL;
> adev->accel_working = false;
> /* free i2c buses */
> --
> 1.7.9.5
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> http://lists.freedesktop.org/mailman/listinfo/dri-devel