2015-06-26 11:17:13

by Ivan T. Ivanov

Subject: [PATCH] mmc: sdhci: msm: Boost controller core clock

Ensure SDCC is working with maximum clock otherwise card
detection could be extremely slow, up to 7 seconds.

Signed-off-by: Ivan T. Ivanov <[email protected]>
---
drivers/mmc/host/sdhci-msm.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 4a09f76..b2556bc 100644
--- a/drivers/mmc/host/sdhci-msm.c
+++ b/drivers/mmc/host/sdhci-msm.c
@@ -489,6 +489,11 @@ static int sdhci_msm_probe(struct platform_device *pdev)
goto pclk_disable;
}

+ /* Vote for maximum clock rate for maximum performance */
+ ret = clk_set_rate(msm_host->clk, INT_MAX);
+ if (ret)
+ dev_warn(&pdev->dev, "core clock boost falied\n");
+
ret = clk_prepare_enable(msm_host->clk);
if (ret)
goto pclk_disable;
--
1.9.1

2015-06-26 11:35:06

by Georgi Djakov

Subject: Re: [PATCH] mmc: sdhci: msm: Boost controller core clock

On 06/26/2015 02:16 PM, Ivan T. Ivanov wrote:
> Ensure SDCC is working with maximum clock otherwise card
> detection could be extremely slow, up to 7 seconds.
>
> Signed-off-by: Ivan T. Ivanov <[email protected]>
> ---
> drivers/mmc/host/sdhci-msm.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index 4a09f76..b2556bc 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -489,6 +489,11 @@ static int sdhci_msm_probe(struct platform_device *pdev)
> goto pclk_disable;
> }
>
> + /* Vote for maximum clock rate for maximum performance */
> + ret = clk_set_rate(msm_host->clk, INT_MAX);
> + if (ret)
> + dev_warn(&pdev->dev, "core clock boost falied\n");

failed?

Otherwise looks good to me.

> +
> ret = clk_prepare_enable(msm_host->clk);
> if (ret)
> goto pclk_disable;
> --
> 1.9.1
>

2015-06-26 11:59:34

by Ivan T. Ivanov

Subject: Re: [PATCH] mmc: sdhci: msm: Boost controller core clock

On Fri, 2015-06-26 at 14:34 +0300, Georgi Djakov wrote:
> On 06/26/2015 02:16 PM, Ivan T. Ivanov wrote:
> > Ensure SDCC is working with maximum clock otherwise card
> > detection could be extremely slow, up to 7 seconds.
> >
> > Signed-off-by: Ivan T. Ivanov [email protected]>
> > ---
> > drivers/mmc/host/sdhci-msm.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> > index 4a09f76..b2556bc 100644
> > --- a/drivers/mmc/host/sdhci-msm.c
> > +++ b/drivers/mmc/host/sdhci-msm.c
> > @@ -489,6 +489,11 @@ static int sdhci_msm_probe(struct platform_device *pdev)
> > goto pclk_disable;
> > }
> >
> > + /* Vote for maximum clock rate for maximum performance */
> > + ret = clk_set_rate(msm_host->clk, INT_MAX);
> > + if (ret)
> > + dev_warn(&pdev->dev, "core clock boost falied\n");
>
> failed?
>
> Otherwise looks good to me.
>

Oops, will fix.

Thanks,
Ivan

> > +
> > ret = clk_prepare_enable(msm_host->clk);
> > if (ret)
> > goto pclk_disable;
> > --
> > 1.9.1
> >
>
>

2015-07-02 00:18:11

by Stephen Boyd

Subject: Re: [PATCH] mmc: sdhci: msm: Boost controller core clock

On 06/26/2015 04:16 AM, Ivan T. Ivanov wrote:
> Ensure SDCC is working with maximum clock otherwise card
> detection could be extremely slow, up to 7 seconds.
>
> Signed-off-by: Ivan T. Ivanov <[email protected]>
> ---

With the typo fixed.

Acked-by: Stephen Boyd <[email protected]>

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project