2015-06-26 14:55:00

by Constantine Shulyupin

[permalink] [raw]
Subject: [PATCH] hwmon: (nct7802) fix visibility of temp3

From: const <[email protected]>

Excerpt from datasheet:
7.2.32 Mode Selection Register
RTD3_MD : 00=Closed , 01=Reserved , 10=Thermistor mode , 11=Voltage sense

Show temp3 only in Thermistor mode

Signed-off-by: Constantine Shulyupin <[email protected]>
---
drivers/hwmon/nct7802.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c
index 5418417..dcca5fc 100644
--- a/drivers/hwmon/nct7802.c
+++ b/drivers/hwmon/nct7802.c
@@ -649,7 +649,7 @@ static umode_t nct7802_temp_is_visible(struct kobject *kobj,
if (index >= 9 && index < 18 &&
(reg & 0x0c) != 0x04 && (reg & 0x0c) != 0x08) /* RD2 */
return 0;
- if (index >= 18 && index < 27 && (reg & 0x30) != 0x10) /* RD3 */
+ if (index >= 18 && index < 27 && (reg & 0x30) != 0x20) /* RD3 */
return 0;
if (index >= 27 && index < 35) /* local */
return attr->mode;
--
1.9.1


2015-06-26 15:17:47

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH] hwmon: (nct7802) fix visibility of temp3

On Fri, Jun 26, 2015 at 05:47:44PM +0300, Constantine Shulyupin wrote:
> From: const <[email protected]>
>
> Excerpt from datasheet:
> 7.2.32 Mode Selection Register
> RTD3_MD : 00=Closed , 01=Reserved , 10=Thermistor mode , 11=Voltage sense
>
> Show temp3 only in Thermistor mode
>
> Signed-off-by: Constantine Shulyupin <[email protected]>

Thanks, applied. I'll also submit the patch to -stable releases as needed.

Guenter