2015-06-09 18:00:10

by Marc Zyngier

[permalink] [raw]
Subject: Re: [PATCH v5 1/2] arm64: kvm: allows kvm cpu hotplug

Hi Takahiro,

On 29/05/15 06:38, AKASHI Takahiro wrote:
> The current kvm implementation on arm64 does cpu-specific initialization
> at system boot, and has no way to gracefully shutdown a core in terms of
> kvm. This prevents, especially, kexec from rebooting the system on a boot
> core in EL2.
>
> This patch adds a cpu tear-down function and also puts an existing cpu-init
> code into a separate function, kvm_arch_hardware_disable() and
> kvm_arch_hardware_enable() respectively.
> We don't need arm64-specific cpu hotplug hook any more.
>
> Since this patch modifies common part of code between arm and arm64, one
> stub definition, __cpu_reset_hyp_mode(), is added on arm side to avoid
> compiling errors.
>
> Signed-off-by: AKASHI Takahiro <[email protected]>

This is starting to look good. Any chance you or Geoff could repost the
whole series? This would help getting a better view of the whole thing,
and hopefully put it on track for 4.3.

Thanks,

M.
--
Jazz is not dead. It just smells funny...


2015-07-06 14:53:09

by Marc Zyngier

[permalink] [raw]
Subject: Re: [PATCH v5 1/2] arm64: kvm: allows kvm cpu hotplug

On 09/06/15 19:00, Marc Zyngier wrote:
> Hi Takahiro,
>
> On 29/05/15 06:38, AKASHI Takahiro wrote:
>> The current kvm implementation on arm64 does cpu-specific initialization
>> at system boot, and has no way to gracefully shutdown a core in terms of
>> kvm. This prevents, especially, kexec from rebooting the system on a boot
>> core in EL2.
>>
>> This patch adds a cpu tear-down function and also puts an existing cpu-init
>> code into a separate function, kvm_arch_hardware_disable() and
>> kvm_arch_hardware_enable() respectively.
>> We don't need arm64-specific cpu hotplug hook any more.
>>
>> Since this patch modifies common part of code between arm and arm64, one
>> stub definition, __cpu_reset_hyp_mode(), is added on arm side to avoid
>> compiling errors.
>>
>> Signed-off-by: AKASHI Takahiro <[email protected]>
>
> This is starting to look good. Any chance you or Geoff could repost the
> whole series? This would help getting a better view of the whole thing,
> and hopefully put it on track for 4.3.

So this has now been a whole month since I reviewed this, and I haven't
seen any repost of this series. Any hope to see this within a reasonable
time frame? Or is it considered dead already?

Thanks,

M.
--
Jazz is not dead. It just smells funny...

2015-07-06 16:58:07

by Geoff Levand

[permalink] [raw]
Subject: Re: [PATCH v5 1/2] arm64: kvm: allows kvm cpu hotplug

Hi Marc,

On Mon, 2015-07-06 at 15:53 +0100, Marc Zyngier wrote:
> So this has now been a whole month since I reviewed this, and I haven't
> seen any repost of this series. Any hope to see this within a reasonable
> time frame? Or is it considered dead already?

I was hoping to do some work on updating the base kexec patches
last week, but all my time was taken up but other things. I'll
try to start on it this week.

-Geoff

2015-07-07 07:43:19

by AKASHI Takahiro

[permalink] [raw]
Subject: Re: [PATCH v5 1/2] arm64: kvm: allows kvm cpu hotplug

On 07/07/2015 01:57 AM, Geoff Levand wrote:
> Hi Marc,
>
> On Mon, 2015-07-06 at 15:53 +0100, Marc Zyngier wrote:
>> So this has now been a whole month since I reviewed this, and I haven't
>> seen any repost of this series. Any hope to see this within a reasonable
>> time frame? Or is it considered dead already?
>
> I was hoping to do some work on updating the base kexec patches
> last week, but all my time was taken up but other things. I'll
> try to start on it this week.

I also have some update, and so will submit my patchset
after Geoff. Pratyush's patch should also be synced.

-Takahiro AKASHI


> -Geoff
>

2015-07-07 07:46:12

by Marc Zyngier

[permalink] [raw]
Subject: Re: [PATCH v5 1/2] arm64: kvm: allows kvm cpu hotplug

On 07/07/15 08:43, AKASHI Takahiro wrote:
> On 07/07/2015 01:57 AM, Geoff Levand wrote:
>> Hi Marc,
>>
>> On Mon, 2015-07-06 at 15:53 +0100, Marc Zyngier wrote:
>>> So this has now been a whole month since I reviewed this, and I haven't
>>> seen any repost of this series. Any hope to see this within a reasonable
>>> time frame? Or is it considered dead already?
>>
>> I was hoping to do some work on updating the base kexec patches
>> last week, but all my time was taken up but other things. I'll
>> try to start on it this week.
>
> I also have some update, and so will submit my patchset
> after Geoff. Pratyush's patch should also be synced.

Please coordinate between all of you and post a consistent series. It
was painful enough to review the KVM stuff independently of the rest of
the series, so I'd really really want to see a single series that
addresses the issue end to end.

Thanks,

M.
--
Jazz is not dead. It just smells funny...