2015-07-07 05:48:25

by Ian Munsie

Subject: [PATCH 1/2] cxl: Fix off by one error allowing subsequent mmap page to be accessed

From: Ian Munsie <[email protected]>

It was discovered that if a process mmaped their problem state area they
were able to access one page more than expected, potentially allowing
them to access the problem state area of an unrelated process.

This was due to a simple off by one error in the mmap fault handler
introduced in 0712dc7e73e59d79bcead5d5520acf4e9e917e87 ("cxl: Fix issues
when unmapping contexts"), which is fixed in this patch.

Cc: [email protected]
Fixes: 0712dc7e73e5 ("cxl: Fix issues when unmapping contexts")
Signed-off-by: Ian Munsie <[email protected]>
---
drivers/misc/cxl/context.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/cxl/context.c b/drivers/misc/cxl/context.c
index 2a4c80a..6c1ce51 100644
--- a/drivers/misc/cxl/context.c
+++ b/drivers/misc/cxl/context.c
@@ -113,11 +113,11 @@ static int cxl_mmap_fault(struct vm_area_struct *vma, struct vm_fault *vmf)

if (ctx->afu->current_mode == CXL_MODE_DEDICATED) {
area = ctx->afu->psn_phys;
- if (offset > ctx->afu->adapter->ps_size)
+ if (offset >= ctx->afu->adapter->ps_size)
return VM_FAULT_SIGBUS;
} else {
area = ctx->psn_phys;
- if (offset > ctx->psn_size)
+ if (offset >= ctx->psn_size)
return VM_FAULT_SIGBUS;
}

--
2.1.4

2015-07-07 05:48:14

by Ian Munsie

Subject: [PATCH 2/2] cxl: Fail mmap if requested mapping is larger than assigned problem state area

From: Ian Munsie <[email protected]>

This patch makes the mmap call fail outright if the requested region is
larger than the problem state area assigned to the context so the error
is reported immediately rather than waiting for an attempt to access an
address out of bounds.

Although we never expect users to map more than the assigned problem
state area and are not aware of anyone doing this (other than for
testing), this does have the potential to break users if someone has
used a larger range regardless. I'm submitting it for consideration, but
if this change is not considered acceptable the previous patch is
sufficient to prevent access out of bounds without breaking anyone.

Signed-off-by: Ian Munsie <[email protected]>
---
drivers/misc/cxl/context.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/misc/cxl/context.c b/drivers/misc/cxl/context.c
index 6c1ce51..1287148 100644
--- a/drivers/misc/cxl/context.c
+++ b/drivers/misc/cxl/context.c
@@ -145,8 +145,16 @@ static const struct vm_operations_struct cxl_mmap_vmops = {
*/
int cxl_context_iomap(struct cxl_context *ctx, struct vm_area_struct *vma)
{
+ u64 start = vma->vm_pgoff << PAGE_SHIFT;
u64 len = vma->vm_end - vma->vm_start;
- len = min(len, ctx->psn_size);
+
+ if (ctx->afu->current_mode == CXL_MODE_DEDICATED) {
+ if (start + len > ctx->afu->adapter->ps_size)
+ return -EINVAL;
+ } else {
+ if (start + len > ctx->psn_size)
+ return -EINVAL;
+ }

if (ctx->afu->current_mode != CXL_MODE_DEDICATED) {
/* make sure there is a valid per process space for this AFU */
--
2.1.4

2015-07-08 10:54:14

by Michael Ellerman

Subject: Re: [1/2] cxl: Fix off by one error allowing subsequent mmap page to be accessed

On Tue, 2015-07-07 at 05:45:45 UTC, Ian Munsie wrote:
> From: Ian Munsie <[email protected]>
>
> It was discovered that if a process mmaped their problem state area they
> were able to access one page more than expected, potentially allowing
> them to access the problem state area of an unrelated process.
>
> This was due to a simple off by one error in the mmap fault handler
> introduced in 0712dc7e73e59d79bcead5d5520acf4e9e917e87 ("cxl: Fix issues
> when unmapping contexts"), which is fixed in this patch.
>
> Cc: [email protected]
> Fixes: 0712dc7e73e5 ("cxl: Fix issues when unmapping contexts")
> Signed-off-by: Ian Munsie <[email protected]>

Applied to powerpc fixes, thanks.

https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/commit/?h=fixes&id=10a5894f2dedd8a26b3132497445b314c0d952c4

cheers

2015-07-08 10:54:16

by Michael Ellerman

Subject: Re: [2/2] cxl: Fail mmap if requested mapping is larger than assigned problem state area

On Tue, 2015-07-07 at 05:45:46 UTC, Ian Munsie wrote:
> From: Ian Munsie <[email protected]>
>
> This patch makes the mmap call fail outright if the requested region is
> larger than the problem state area assigned to the context so the error
> is reported immediately rather than waiting for an attempt to access an
> address out of bounds.
>
> Although we never expect users to map more than the assigned problem
> state area and are not aware of anyone doing this (other than for
> testing), this does have the potential to break users if someone has
> used a larger range regardless. I'm submitting it for consideration, but
> if this change is not considered acceptable the previous patch is
> sufficient to prevent access out of bounds without breaking anyone.
>
> Signed-off-by: Ian Munsie <[email protected]>

Applied to powerpc fixes, thanks.

https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/commit/?h=fixes&id=5caaf5346892d1e7f0b8b7223062644f8538483f

cheers