2015-07-08 15:14:42

by Johannes Thumshirn

Subject: [PATCH] cxl: Destroy cxl_adapter_idr on module_exit

Destroy cxl_adapter_idr on module exit, reclaiming the allocated memory.

This was detected by the following semantic patch (written by Luis Rodriguez
<[email protected]>)
<SmPL>
@ defines_module_init @
declarer name module_init, module_exit;
declarer name DEFINE_IDR;
identifier init;
@@

module_init(init);

@ defines_module_exit @
identifier exit;
@@

module_exit(exit);

@ declares_idr depends on defines_module_init && defines_module_exit @
identifier idr;
@@

DEFINE_IDR(idr);

@ on_exit_calls_destroy depends on declares_idr && defines_module_exit @
identifier declares_idr.idr, defines_module_exit.exit;
@@

exit(void)
{
...
idr_destroy(&idr);
...
}

@ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @
identifier declares_idr.idr, defines_module_exit.exit;
@@

exit(void)
{
...
+idr_destroy(&idr);
}
</SmPL>

Signed-off-by: Johannes Thumshirn <[email protected]>
---
drivers/misc/cxl/main.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/misc/cxl/main.c b/drivers/misc/cxl/main.c
index 833348e..4e58e0b 100644
--- a/drivers/misc/cxl/main.c
+++ b/drivers/misc/cxl/main.c
@@ -222,6 +222,7 @@ static void exit_cxl(void)
cxl_debugfs_exit();
cxl_file_exit();
unregister_cxl_calls(&cxl_calls);
+ idr_destroy(&cxl_adapter_idr);
}

module_init(init_cxl);
--
2.4.3

2015-07-09 01:59:11

by Ian Munsie

Subject: Re: [PATCH] cxl: Destroy cxl_adapter_idr on module_exit

Acked-by: Ian Munsie <[email protected]>

We are probably also missing an idr_destroy(&afu->contexts_idr); in
cxl_release_afu() as well if you wanted to send a patch for that.

Cheers,
-Ian

2015-07-09 06:54:08

by Johannes Thumshirn

Subject: Re: [PATCH] cxl: Destroy cxl_adapter_idr on module_exit

Ian Munsie <[email protected]> writes:

> Acked-by: Ian Munsie <[email protected]>
>
> We are probably also missing an idr_destroy(&afu->contexts_idr); in
> cxl_release_afu() as well if you wanted to send a patch for that.
>
> Cheers,
> -Ian
>

Correct, patch is going out today. Thanks for the hint.

--
Johannes Thumshirn Storage
[email protected] +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

2015-07-16 09:55:05

by Michael Ellerman

Subject: Re: cxl: Destroy cxl_adapter_idr on module_exit

On Wed, 2015-08-07 at 15:14:36 UTC, Johannes Thumshirn wrote:
> Destroy cxl_adapter_idr on module exit, reclaiming the allocated memory.
>
> Signed-off-by: Johannes Thumshirn <[email protected]>
> Acked-by: Ian Munsie <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/b2a02ac65e40fb3900d1

cheers