2015-07-09 02:51:40

by Ronit Halder

Subject: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue

From: Ronit Halder <[email protected]>

Fixed a coding style issue.

Signed-off-by: Ronit Halder <[email protected]>
---
drivers/staging/android/ion/ion.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 6f48112..e44f5e6 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
struct ion_buffer *buffer;
struct dma_buf *dmabuf;
bool valid_handle;
+
DEFINE_DMA_BUF_EXPORT_INFO(exp_info);

mutex_lock(&client->lock);
--
1.9.1

2015-07-09 05:36:10

by Sudip Mukherjee

Subject: Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue

On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote:
> From: Ronit Halder <[email protected]>

You do not need a From: here. Please fix your gitconfig file and
git send-email will give your name correctly in the email header.

regards
sudip

2015-07-09 05:59:08

by Ronit Halder

Subject: Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue

On Thu, 2015-07-09 at 11:05 +0530, Sudip Mukherjee wrote:
> On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote:
> > From: Ronit Halder <[email protected]>
>
> You do not need a From: here. Please fix your gitconfig file and
> git send-email will give your name correctly in the email header.
>
> regards
> sudip
thanks for pointing it sudip.
Sorry for the stupid mistake, version 2 of the patch is coming.

2015-07-09 05:59:45

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue

On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote:
> From: Ronit Halder <[email protected]>
>
> Fixed a coding style issue.
>
> Signed-off-by: Ronit Halder <[email protected]>
> ---
> drivers/staging/android/ion/ion.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 6f48112..e44f5e6 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
> struct ion_buffer *buffer;
> struct dma_buf *dmabuf;
> bool valid_handle;
> +
> DEFINE_DMA_BUF_EXPORT_INFO(exp_info);

This is a false positive and has been rejected so many times it's really
getting old...

2015-07-09 09:58:01

by Joe Perches

Subject: Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue

On Wed, 2015-07-08 at 22:59 -0700, Greg KH wrote:
> On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote:
> > Fixed a coding style issue.
[]
> > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
[]
> @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
> > struct ion_buffer *buffer;
> > struct dma_buf *dmabuf;
> > bool valid_handle;
> > +
> > DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
>
> This is a false positive and has been rejected so many times it's really
> getting old...

There's a checkpatch patch for that that'll eventually get applied.

https://lkml.org/lkml/2015/7/1/383