2015-07-09 06:10:13

by Ronit Halder

Subject: [PATCH v2] Staging: android: ion: fixed a blank line after declarations coding style issue

Fixed a coding style issue.

Signed-off-by: Ronit Halder <[email protected]>
---
drivers/staging/android/ion/ion.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 6f48112..e44f5e6 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
struct ion_buffer *buffer;
struct dma_buf *dmabuf;
bool valid_handle;
+
DEFINE_DMA_BUF_EXPORT_INFO(exp_info);

mutex_lock(&client->lock);
--
1.9.1

2015-07-09 06:27:20

by Sudip Mukherjee

Subject: Re: [PATCH v2] Staging: android: ion: fixed a blank line after declarations coding style issue

On Thu, Jul 09, 2015 at 11:39:11AM +0530, Ronit Halder wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Ronit Halder <[email protected]>
Greg has commented in your v1 that it is a false positive. See that:
#define DEFINE_DMA_BUF_EXPORT_INFO(a) \
struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME }

so blank line will not be required here.

regards
sudip