2015-07-10 00:46:55

by Jacob Kiefer

Subject: [PATCH] staging: style fix for octeon/ethernet-tx.c

From: Jacob Kiefer <[email protected]>

Style fix for octeon/ethernet-tx.c

Signed-off-by: Jacob Kiefer <[email protected]>
---
drivers/staging/octeon/ethernet-tx.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c
index 7c1c1b0..e2df041 100644
--- a/drivers/staging/octeon/ethernet-tx.c
+++ b/drivers/staging/octeon/ethernet-tx.c
@@ -396,10 +396,12 @@ dont_put_skbuff_in_hw:

/* Check if we can use the hardware checksumming */
if ((skb->protocol == htons(ETH_P_IP)) &&
- (ip_hdr(skb)->version == 4) && (ip_hdr(skb)->ihl == 5) &&
- ((ip_hdr(skb)->frag_off == 0) || (ip_hdr(skb)->frag_off == htons(1 << 14)))
- && ((ip_hdr(skb)->protocol == IPPROTO_TCP)
- || (ip_hdr(skb)->protocol == IPPROTO_UDP))) {
+ (ip_hdr(skb)->version == 4) &&
+ (ip_hdr(skb)->ihl == 5) &&
+ ((ip_hdr(skb)->frag_off == 0) ||
+ (ip_hdr(skb)->frag_off == htons(1 << 14))) &&
+ ((ip_hdr(skb)->protocol == IPPROTO_TCP) ||
+ (ip_hdr(skb)->protocol == IPPROTO_UDP))) {
/* Use hardware checksum calc */
pko_command.s.ipoffp1 = sizeof(struct ethhdr) + 1;
}
--
1.8.3.2

2015-07-10 04:55:16

by Sudip Mukherjee

Subject: Re: [PATCH] staging: style fix for octeon/ethernet-tx.c

On Thu, Jul 09, 2015 at 08:46:04PM -0400, Jacob Kiefer wrote:
> From: Jacob Kiefer <[email protected]>
No need to mention this From: as it will come from the email header.
>
> Style fix for octeon/ethernet-tx.c
Please mention which style you have fixed.

regards
sudip