2015-07-10 09:44:12

by Alison Wang

Subject: [PATCH] arm: ls1021a: utilize hrtimer based broadcast mode

Hrtimer based broadcast mode is used instead of
periodic tick broadcast to provide high resolution
clock in SMP.

Signed-off-by: Alison Wang <[email protected]>
---
arch/arm/mach-imx/mach-ls1021a.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/arch/arm/mach-imx/mach-ls1021a.c b/arch/arm/mach-imx/mach-ls1021a.c
index b89c858..1a1a115 100644
--- a/arch/arm/mach-imx/mach-ls1021a.c
+++ b/arch/arm/mach-imx/mach-ls1021a.c
@@ -8,9 +8,19 @@
*/

#include <asm/mach/arch.h>
+#include <linux/clk-provider.h>
+#include <linux/clockchips.h>
+#include <linux/clocksource.h>

#include "common.h"

+static void __init ls1021a_init_time(void)
+{
+ of_clk_init(NULL);
+ clocksource_of_init();
+ tick_setup_hrtimer_broadcast();
+}
+
static const char * const ls1021a_dt_compat[] __initconst = {
"fsl,ls1021a",
NULL,
@@ -18,5 +28,6 @@ static const char * const ls1021a_dt_compat[] __initconst = {

DT_MACHINE_START(LS1021A, "Freescale LS1021A")
.smp = smp_ops(ls1021a_smp_ops),
+ .init_time = ls1021a_init_time,
.dt_compat = ls1021a_dt_compat,
MACHINE_END
--
2.1.0.27.g96db324

2015-07-10 15:00:38

by Mark Rutland

Subject: Re: [PATCH] arm: ls1021a: utilize hrtimer based broadcast mode

On Fri, Jul 10, 2015 at 10:39:05AM +0100, Alison Wang wrote:
> Hrtimer based broadcast mode is used instead of
> periodic tick broadcast to provide high resolution
> clock in SMP.
>
> Signed-off-by: Alison Wang <[email protected]>
> ---
> arch/arm/mach-imx/mach-ls1021a.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/mach-imx/mach-ls1021a.c b/arch/arm/mach-imx/mach-ls1021a.c
> index b89c858..1a1a115 100644
> --- a/arch/arm/mach-imx/mach-ls1021a.c
> +++ b/arch/arm/mach-imx/mach-ls1021a.c
> @@ -8,9 +8,19 @@
> */
>
> #include <asm/mach/arch.h>
> +#include <linux/clk-provider.h>
> +#include <linux/clockchips.h>
> +#include <linux/clocksource.h>
>
> #include "common.h"
>
> +static void __init ls1021a_init_time(void)
> +{
> + of_clk_init(NULL);
> + clocksource_of_init();
> + tick_setup_hrtimer_broadcast();
> +}

It would be nicer to place this in the arch time_init() function, as
already happens for arm64 and powerpc. That way everyone can benefit.

Thanks,
Mark.

> +
> static const char * const ls1021a_dt_compat[] __initconst = {
> "fsl,ls1021a",
> NULL,
> @@ -18,5 +28,6 @@ static const char * const ls1021a_dt_compat[] __initconst = {
>
> DT_MACHINE_START(LS1021A, "Freescale LS1021A")
> .smp = smp_ops(ls1021a_smp_ops),
> + .init_time = ls1021a_init_time,
> .dt_compat = ls1021a_dt_compat,
> MACHINE_END
> --
> 2.1.0.27.g96db324
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

2015-07-14 10:12:30

by Huan Wang

Subject: RE: [PATCH] arm: ls1021a: utilize hrtimer based broadcast mode

Hi, Mark,

> On Fri, Jul 10, 2015 at 10:39:05AM +0100, Alison Wang wrote:
> > Hrtimer based broadcast mode is used instead of periodic tick
> > broadcast to provide high resolution clock in SMP.
> >
> > Signed-off-by: Alison Wang <[email protected]>
> > ---
> > arch/arm/mach-imx/mach-ls1021a.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm/mach-imx/mach-ls1021a.c
> > b/arch/arm/mach-imx/mach-ls1021a.c
> > index b89c858..1a1a115 100644
> > --- a/arch/arm/mach-imx/mach-ls1021a.c
> > +++ b/arch/arm/mach-imx/mach-ls1021a.c
> > @@ -8,9 +8,19 @@
> > */
> >
> > #include <asm/mach/arch.h>
> > +#include <linux/clk-provider.h>
> > +#include <linux/clockchips.h>
> > +#include <linux/clocksource.h>
> >
> > #include "common.h"
> >
> > +static void __init ls1021a_init_time(void) {
> > + of_clk_init(NULL);
> > + clocksource_of_init();
> > + tick_setup_hrtimer_broadcast();
> > +}
>
> It would be nicer to place this in the arch time_init() function, as
> already happens for arm64 and powerpc. That way everyone can benefit.
[Alison Wang] Yes, I think so.
Thanks.
>
> Thanks,
> Mark.
>
> > +
> > static const char * const ls1021a_dt_compat[] __initconst = {
> > "fsl,ls1021a",
> > NULL,
> > @@ -18,5 +28,6 @@ static const char * const ls1021a_dt_compat[]
> > __initconst = {
> >
> > DT_MACHINE_START(LS1021A, "Freescale LS1021A")
> > .smp = smp_ops(ls1021a_smp_ops),
> > + .init_time = ls1021a_init_time,
> > .dt_compat = ls1021a_dt_compat,
> > MACHINE_END
> > --
> > 2.1.0.27.g96db324
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > [email protected]
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >