2015-07-15 08:00:35

by Alison Wang

Subject: [PATCH v2] ARM: dts: ls1021a: add wakeup device ftm0 node for ls1021a

Add ftm0 node, cause of ftm0 can be set as a alarm before system
going to deep sleep.

Signed-off-by: Wang Dongsheng <[email protected]>
Signed-off-by: Alison Wang <[email protected]>
---
Changes since v1:
- Add my SoB.
- Use "ARM:" as subject prefix.

arch/arm/boot/dts/ls1021a-qds.dts | 4 ++++
arch/arm/boot/dts/ls1021a.dtsi | 8 ++++++++
2 files changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts
index 9c5e16b..f14731b 100644
--- a/arch/arm/boot/dts/ls1021a-qds.dts
+++ b/arch/arm/boot/dts/ls1021a-qds.dts
@@ -75,6 +75,10 @@
};
};

+&ftm0 {
+ status = "okay";
+};
+
&i2c0 {
status = "okay";

diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index c70bb27..7e9e122 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -332,6 +332,14 @@
status = "disabled";
};

+ ftm0: ftm0@29d0000 {
+ compatible = "fsl,ftm-alarm";
+ reg = <0x0 0x29d0000 0x0 0x10000>;
+ interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
+ big-endian;
+ status = "disabled";
+ };
+
wdog0: watchdog@2ad0000 {
compatible = "fsl,imx21-wdt";
reg = <0x0 0x2ad0000 0x0 0x10000>;
--
2.1.0.27.g96db324

2015-07-28 01:50:01

by Shawn Guo

Subject: Re: [PATCH v2] ARM: dts: ls1021a: add wakeup device ftm0 node for ls1021a

On Wed, Jul 15, 2015 at 03:40:11PM +0800, Alison Wang wrote:
> Add ftm0 node, cause of ftm0 can be set as a alarm before system
> going to deep sleep.
>
> Signed-off-by: Wang Dongsheng <[email protected]>
> Signed-off-by: Alison Wang <[email protected]>
> ---
> Changes since v1:
> - Add my SoB.
> - Use "ARM:" as subject prefix.
>
> arch/arm/boot/dts/ls1021a-qds.dts | 4 ++++
> arch/arm/boot/dts/ls1021a.dtsi | 8 ++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts
> index 9c5e16b..f14731b 100644
> --- a/arch/arm/boot/dts/ls1021a-qds.dts
> +++ b/arch/arm/boot/dts/ls1021a-qds.dts
> @@ -75,6 +75,10 @@
> };
> };
>
> +&ftm0 {
> + status = "okay";
> +};
> +
> &i2c0 {
> status = "okay";
>
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index c70bb27..7e9e122 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -332,6 +332,14 @@
> status = "disabled";
> };
>
> + ftm0: ftm0@29d0000 {

Is the '0' in the node name is an instance number? If so, please drop
it from node name.
ftm0: ftm@29d0000 {

> + compatible = "fsl,ftm-alarm";

Undocumented compatible string.

Shawn

> + reg = <0x0 0x29d0000 0x0 0x10000>;
> + interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
> + big-endian;
> + status = "disabled";
> + };
> +
> wdog0: watchdog@2ad0000 {
> compatible = "fsl,imx21-wdt";
> reg = <0x0 0x2ad0000 0x0 0x10000>;
> --
> 2.1.0.27.g96db324
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

2015-07-28 02:01:39

by Wang Dongsheng

Subject: RE: [PATCH v2] ARM: dts: ls1021a: add wakeup device ftm0 node for ls1021a

Hi Shawn,

> -----Original Message-----
> From: Shawn Guo [mailto:[email protected]]
> Sent: Tuesday, July 28, 2015 9:50 AM
> To: Wang Huan-B18965
> Cc: [email protected]; [email protected]; linux-
> [email protected]; Wang Dongsheng-B40534; Wang Huan-B18965
> Subject: Re: [PATCH v2] ARM: dts: ls1021a: add wakeup device ftm0 node for
> ls1021a
>
> On Wed, Jul 15, 2015 at 03:40:11PM +0800, Alison Wang wrote:
> > Add ftm0 node, cause of ftm0 can be set as a alarm before system going
> > to deep sleep.
> >
> > Signed-off-by: Wang Dongsheng <[email protected]>
> > Signed-off-by: Alison Wang <[email protected]>
> > ---
> > Changes since v1:
> > - Add my SoB.
> > - Use "ARM:" as subject prefix.
> >
> > arch/arm/boot/dts/ls1021a-qds.dts | 4 ++++
> > arch/arm/boot/dts/ls1021a.dtsi | 8 ++++++++
> > 2 files changed, 12 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/ls1021a-qds.dts
> > b/arch/arm/boot/dts/ls1021a-qds.dts
> > index 9c5e16b..f14731b 100644
> > --- a/arch/arm/boot/dts/ls1021a-qds.dts
> > +++ b/arch/arm/boot/dts/ls1021a-qds.dts
> > @@ -75,6 +75,10 @@
> > };
> > };
> >
> > +&ftm0 {
> > + status = "okay";
> > +};
> > +
> > &i2c0 {
> > status = "okay";
> >
> > diff --git a/arch/arm/boot/dts/ls1021a.dtsi
> > b/arch/arm/boot/dts/ls1021a.dtsi index c70bb27..7e9e122 100644
> > --- a/arch/arm/boot/dts/ls1021a.dtsi
> > +++ b/arch/arm/boot/dts/ls1021a.dtsi
> > @@ -332,6 +332,14 @@
> > status = "disabled";
> > };
> >
> > + ftm0: ftm0@29d0000 {
>
> Is the '0' in the node name is an instance number? If so, please drop it from
> node name.

"0" is a special number for FTM, because there is only ftm0 can be maked as a alarm timer.

Regards,
-Dongsheng