2015-07-16 20:28:39

by Laurent Navet

[permalink] [raw]
Subject: [PATCH] i2c: s3c2410: remove unused variable

ret is assigned zero and just used to return. remove it.
Found by using coccinelle.

Signed-off-by: Laurent Navet <[email protected]>
---
drivers/i2c/busses/i2c-s3c2410.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 50bfd8c..cf3c6c0 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -409,7 +409,6 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
{
unsigned long tmp;
unsigned char byte;
- int ret = 0;

switch (i2c->state) {

@@ -565,7 +564,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
tmp &= ~S3C2410_IICCON_IRQPEND;
writel(tmp, i2c->regs + S3C2410_IICCON);
out:
- return ret;
+ return 0;
}

/* s3c24xx_i2c_irq
--
2.1.4


2015-07-16 20:40:34

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] i2c: s3c2410: remove unused variable

On Thu, Jul 16, 2015 at 10:36:16PM +0200, Laurent Navet wrote:
> ret is assigned zero and just used to return. remove it.
> Found by using coccinelle.
>
> Signed-off-by: Laurent Navet <[email protected]>

Why not make it void?


Attachments:
(No filename) (235.00 B)
signature.asc (819.00 B)
Digital signature
Download all attachments