2015-07-22 19:43:11

by Bjorn Andersson

[permalink] [raw]
Subject: [PATCH] genirq: Export irq_{get,set}_irqchip_state()

Export these functions to be able to build the Qualcomm family A PMIC
gpio and mpp drivers as modules.

Signed-off-by: Bjorn Andersson <[email protected]>
---
kernel/irq/manage.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index f9744853b656..3ceedb34e38b 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -1875,6 +1875,7 @@ int irq_get_irqchip_state(unsigned int irq, enum irqchip_irq_state which,
irq_put_desc_busunlock(desc, flags);
return err;
}
+EXPORT_SYMBOL(irq_get_irqchip_state);

/**
* irq_set_irqchip_state - set the state of a forwarded interrupt.
@@ -1920,3 +1921,4 @@ int irq_set_irqchip_state(unsigned int irq, enum irqchip_irq_state which,
irq_put_desc_busunlock(desc, flags);
return err;
}
+EXPORT_SYMBOL(irq_set_irqchip_state);
--
1.8.2.2


2015-07-24 10:53:30

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] genirq: Export irq_{get,set}_irqchip_state()

On Wed, Jul 22, 2015 at 12:43:04PM -0700, Bjorn Andersson wrote:
> Export these functions to be able to build the Qualcomm family A PMIC
> gpio and mpp drivers as modules.

Reviwed-by: Mark Brown <[email protected]>

This is breaking the allmodconfig build on at least ARM platforms in
-next, it'd be really good to get it applied.

Attachments:
(No filename) (333.00 B)
 signature.asc (473.00 B)
Digital signature Download all attachments
Subject: [tip:irq/core] genirq: Export irq_[get|set]_irqchip_state()

Commit-ID: 1ee4fb3ee1e47f2b3c294ded383a3cd9cc2decd4
Gitweb: http://git.kernel.org/tip/1ee4fb3ee1e47f2b3c294ded383a3cd9cc2decd4
Author: Bjorn Andersson <[email protected]>
AuthorDate: Wed, 22 Jul 2015 12:43:04 -0700
Committer: Thomas Gleixner <[email protected]>
CommitDate: Mon, 27 Jul 2015 08:09:38 +0200

genirq: Export irq_[get|set]_irqchip_state()

Export these functions to be able to build the Qualcomm family A PMIC
gpio and mpp drivers as modules.

[ tglx: Made them GPL exports ]

Signed-off-by: Bjorn Andersson <[email protected]>
Reviewed-by: Mark Brown <[email protected]>
Cc: Marc Zyngier <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>
Cc: Srinivas Kandagatla <[email protected]>
Cc: Linus Walleij <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thomas Gleixner <[email protected]>
---
kernel/irq/manage.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 886f115..ad1b064 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -1877,6 +1877,7 @@ int irq_get_irqchip_state(unsigned int irq, enum irqchip_irq_state which,
irq_put_desc_busunlock(desc, flags);
return err;
}
+EXPORT_SYMBOL_GPL(irq_get_irqchip_state);

/**
* irq_set_irqchip_state - set the state of a forwarded interrupt.
@@ -1922,3 +1923,4 @@ int irq_set_irqchip_state(unsigned int irq, enum irqchip_irq_state which,
irq_put_desc_busunlock(desc, flags);
return err;
}
+EXPORT_SYMBOL_GPL(irq_set_irqchip_state);

2015-07-27 13:23:10

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] genirq: Export irq_{get,set}_irqchip_state()

On Wed, Jul 22, 2015 at 9:43 PM, Bjorn Andersson
<[email protected]> wrote:

> Export these functions to be able to build the Qualcomm family A PMIC
> gpio and mpp drivers as modules.
>
> Signed-off-by: Bjorn Andersson <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

TGLX: please take this one, alternatively I can carry it with
your ACK.

Yours,
Linus Walleij

2015-07-28 18:50:19

by Thomas Gleixner

[permalink] [raw]
Subject: Re: [PATCH] genirq: Export irq_{get,set}_irqchip_state()

On Mon, 27 Jul 2015, Linus Walleij wrote:

> On Wed, Jul 22, 2015 at 9:43 PM, Bjorn Andersson
> <[email protected]> wrote:
>
> > Export these functions to be able to build the Qualcomm family A PMIC
> > gpio and mpp drivers as modules.
> >
> > Signed-off-by: Bjorn Andersson <[email protected]>
>
> Reviewed-by: Linus Walleij <[email protected]>
>
> TGLX: please take this one, alternatively I can carry it with
> your ACK.

It's queued already.