2015-07-23 10:29:06

by Harini Katakam

[permalink] [raw]
Subject: [NET-NEXT PATCH] net: macb: Change capability mask for jumbo support

JUMBO and NO_GIGABIT_HALF have the same capability masks.
Change one of them.

Signed-off-by: Harini Katakam <[email protected]>
---
drivers/net/ethernet/cadence/macb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
index d746559..8fb80b2 100644
--- a/drivers/net/ethernet/cadence/macb.h
+++ b/drivers/net/ethernet/cadence/macb.h
@@ -399,7 +399,7 @@
#define MACB_CAPS_GIGABIT_MODE_AVAILABLE 0x20000000
#define MACB_CAPS_SG_DISABLED 0x40000000
#define MACB_CAPS_MACB_IS_GEM 0x80000000
-#define MACB_CAPS_JUMBO 0x00000008
+#define MACB_CAPS_JUMBO 0x00000010

/* Bit manipulation macros */
#define MACB_BIT(name) \
--
1.7.9.5


2015-07-23 12:36:17

by Nicolas Ferre

[permalink] [raw]
Subject: Re: [NET-NEXT PATCH] net: macb: Change capability mask for jumbo support

Le 23/07/2015 12:14, Harini Katakam a ?crit :
> JUMBO and NO_GIGABIT_HALF have the same capability masks.
> Change one of them.
>
> Signed-off-by: Harini Katakam <[email protected]>

Yes, indeed:
Acked-by: Nicolas Ferre <[email protected]>

> ---
> drivers/net/ethernet/cadence/macb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
> index d746559..8fb80b2 100644
> --- a/drivers/net/ethernet/cadence/macb.h
> +++ b/drivers/net/ethernet/cadence/macb.h
> @@ -399,7 +399,7 @@
> #define MACB_CAPS_GIGABIT_MODE_AVAILABLE 0x20000000
> #define MACB_CAPS_SG_DISABLED 0x40000000
> #define MACB_CAPS_MACB_IS_GEM 0x80000000
> -#define MACB_CAPS_JUMBO 0x00000008
> +#define MACB_CAPS_JUMBO 0x00000010
>
> /* Bit manipulation macros */
> #define MACB_BIT(name) \
>


--
Nicolas Ferre

2015-07-23 12:42:44

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [NET-NEXT PATCH] net: macb: Change capability mask for jumbo support

On 23/07/2015 at 15:44:25 +0530, Harini Katakam wrote :
> JUMBO and NO_GIGABIT_HALF have the same capability masks.
> Change one of them.
>
> Signed-off-by: Harini Katakam <[email protected]>
Acked-by: Alexandre Belloni <[email protected]>


--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com