2015-07-27 12:17:45

by Kishon Vijay Abraham I

[permalink] [raw]
Subject: [PATCH 0/4] omap: Fix broken pbias device creation

pbias device creation got broken once SCM cleanup got merged.
This patch series re-enables device creation by adding
"simple-bus" in the compatible property of the syscon
dt node.

validated this series in DRA72, OMAP4 PANDA and OMAP5 UEVM
boards.

Kishon Vijay Abraham I (4):
ARM: dts: omap24xx: Fix broken pbias device creation
ARM: dts: OMAP4: Fix broken pbias device creation
ARM: dts: OMAP5: Fix broken pbias device creation
ARM: dts: dra7: Fix broken pbias device creation

arch/arm/boot/dts/dra7.dtsi | 2 +-
arch/arm/boot/dts/omap2430.dtsi | 3 ++-
arch/arm/boot/dts/omap4.dtsi | 3 ++-
arch/arm/boot/dts/omap5.dtsi | 3 ++-
4 files changed, 7 insertions(+), 4 deletions(-)

--
1.7.9.5


2015-07-27 12:17:52

by Kishon Vijay Abraham I

[permalink] [raw]
Subject: [RFT PATCH 1/4] ARM: dts: omap24xx: Fix broken pbias device creation

commit <72b10ac00eb1> ("ARM: dts: omap24xx: add minimal l4 bus
layout with control module support") moved pbias_regulator dt node
from being a child node of ocp to be the child node of
scm_conf. After this device for pbias_regulator is
not created.

Fix it by adding "simple-bus" compatible property to
scm_conf dt node.

Fixes: 72b10ac00eb1 ("ARM: dts: omap24xx: add minimal l4 bus
layout with control module support")

Cc: <[email protected]>
Signed-off-by: Kishon Vijay Abraham I <[email protected]>
---
arch/arm/boot/dts/omap2430.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap2430.dtsi b/arch/arm/boot/dts/omap2430.dtsi
index 11a7963..2390f38 100644
--- a/arch/arm/boot/dts/omap2430.dtsi
+++ b/arch/arm/boot/dts/omap2430.dtsi
@@ -51,7 +51,8 @@
};

scm_conf: scm_conf@270 {
- compatible = "syscon";
+ compatible = "syscon",
+ "simple-bus";
reg = <0x270 0x240>;
#address-cells = <1>;
#size-cells = <1>;
--
1.7.9.5

2015-07-27 12:18:56

by Kishon Vijay Abraham I

[permalink] [raw]
Subject: [PATCH 2/4] ARM: dts: OMAP4: Fix broken pbias device creation

commit <7415b0b4c645> ("ARM: dts: omap4: add minimal l4 bus layout
with control module support") moved pbias_regulator dt node
from being a child node of ocp to be the child node of
omap4_padconf_global. After this device for pbias_regulator
is not created.

Fix it by adding "simple-bus" compatible property to
omap4_padconf_global dt node.

Fixes: 7415b0b4c645 ("ARM: dts: omap4: add minimal l4 bus layout
with control module support")

Cc: <[email protected]>
Signed-off-by: Kishon Vijay Abraham I <[email protected]>
---
arch/arm/boot/dts/omap4.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index 7d31c6f..abc4473 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -191,7 +191,8 @@
};

omap4_padconf_global: omap4_padconf_global@5a0 {
- compatible = "syscon";
+ compatible = "syscon",
+ "simple-bus";
reg = <0x5a0 0x170>;
#address-cells = <1>;
#size-cells = <1>;
--
1.7.9.5

2015-07-27 12:18:07

by Kishon Vijay Abraham I

[permalink] [raw]
Subject: [PATCH 3/4] ARM: dts: OMAP5: Fix broken pbias device creation

commit <ed8509edddeb> ("ARM: dts: omap5: add minimal l4 bus
layout with control module support") moved pbias_regulator dt node
from being a child node of ocp to be the child node of
omap5_padconf_global. After this device for pbias_regulator is
not created.

Fix it by adding "simple-bus" compatible property to
omap5_padconf_global dt node.

Fixes: ed8509edddeb ("ARM: dts: omap5: add minimal l4 bus
layout with control module support")

Cc: <[email protected]>
Signed-off-by: Kishon Vijay Abraham I <[email protected]>
---
arch/arm/boot/dts/omap5.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index c8fd648..b1a1263 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -180,7 +180,8 @@
};

omap5_padconf_global: omap5_padconf_global@5a0 {
- compatible = "syscon";
+ compatible = "syscon",
+ "simple-bus";
reg = <0x5a0 0xec>;
#address-cells = <1>;
#size-cells = <1>;
--
1.7.9.5

2015-07-27 12:17:55

by Kishon Vijay Abraham I

[permalink] [raw]
Subject: [PATCH 4/4] ARM: dts: dra7: Fix broken pbias device creation

commit <d919501feffa> ("ARM: dts: dra7: add minimal l4 bus
layout with control module support") moved pbias_regulator dt node
from being a child node of ocp to be the child node of
scm_conf. After this device for pbias_regulator is
not created.

Fix it by adding "simple-bus" compatible property to
scm_conf dt node.

Fixes: d919501feffa ("ARM: dts: dra7: add minimal l4 bus
layout with control module support")

Cc: <[email protected]>
Suggested-by: Tero Kristo <[email protected]>
Signed-off-by: Kishon Vijay Abraham I <[email protected]>
---
arch/arm/boot/dts/dra7.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 8f1e25b..3062b1f 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -116,7 +116,7 @@
ranges = <0 0x2000 0x2000>;

scm_conf: scm_conf@0 {
- compatible = "syscon";
+ compatible = "syscon", "simple-bus";
reg = <0x0 0x1400>;
#address-cells = <1>;
#size-cells = <1>;
--
1.7.9.5

2015-07-29 08:58:49

by Grygorii Strashko

[permalink] [raw]
Subject: Re: [PATCH 0/4] omap: Fix broken pbias device creation

On 07/27/2015 03:16 PM, Kishon Vijay Abraham I wrote:
> pbias device creation got broken once SCM cleanup got merged.
> This patch series re-enables device creation by adding
> "simple-bus" in the compatible property of the syscon
> dt node.
>
> validated this series in DRA72, OMAP4 PANDA and OMAP5 UEVM
> boards.
>
> Kishon Vijay Abraham I (4):
> ARM: dts: omap24xx: Fix broken pbias device creation
> ARM: dts: OMAP4: Fix broken pbias device creation
> ARM: dts: OMAP5: Fix broken pbias device creation
> ARM: dts: dra7: Fix broken pbias device creation
>
> arch/arm/boot/dts/dra7.dtsi | 2 +-
> arch/arm/boot/dts/omap2430.dtsi | 3 ++-
> arch/arm/boot/dts/omap4.dtsi | 3 ++-
> arch/arm/boot/dts/omap5.dtsi | 3 ++-
> 4 files changed, 7 insertions(+), 4 deletions(-)
>

For dra7-evm:
Tested-by: Grygorii Strashko <[email protected]>

--
regards,
-grygorii

2015-08-05 10:00:15

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH 0/4] omap: Fix broken pbias device creation

* Grygorii Strashko <[email protected]> [150729 02:01]:
> On 07/27/2015 03:16 PM, Kishon Vijay Abraham I wrote:
> >pbias device creation got broken once SCM cleanup got merged.
> >This patch series re-enables device creation by adding
> >"simple-bus" in the compatible property of the syscon
> >dt node.
> >
> >validated this series in DRA72, OMAP4 PANDA and OMAP5 UEVM
> >boards.
> >
> >Kishon Vijay Abraham I (4):
> > ARM: dts: omap24xx: Fix broken pbias device creation
> > ARM: dts: OMAP4: Fix broken pbias device creation
> > ARM: dts: OMAP5: Fix broken pbias device creation
> > ARM: dts: dra7: Fix broken pbias device creation
> >
> > arch/arm/boot/dts/dra7.dtsi | 2 +-
> > arch/arm/boot/dts/omap2430.dtsi | 3 ++-
> > arch/arm/boot/dts/omap4.dtsi | 3 ++-
> > arch/arm/boot/dts/omap5.dtsi | 3 ++-
> > 4 files changed, 7 insertions(+), 4 deletions(-)
> >
>
> For dra7-evm:
> Tested-by: Grygorii Strashko <[email protected]>

Applying all into omap-for-v4.2fixes-v2 thanks.

Tony

2015-08-07 11:48:29

by Peter Robinson

[permalink] [raw]
Subject: Re: [PATCH 0/4] omap: Fix broken pbias device creation

On Wed, Aug 5, 2015 at 11:00 AM, Tony Lindgren <[email protected]> wrote:
> * Grygorii Strashko <[email protected]> [150729 02:01]:
>> On 07/27/2015 03:16 PM, Kishon Vijay Abraham I wrote:
>> >pbias device creation got broken once SCM cleanup got merged.
>> >This patch series re-enables device creation by adding
>> >"simple-bus" in the compatible property of the syscon
>> >dt node.
>> >
>> >validated this series in DRA72, OMAP4 PANDA and OMAP5 UEVM
>> >boards.
>> >
>> >Kishon Vijay Abraham I (4):
>> > ARM: dts: omap24xx: Fix broken pbias device creation
>> > ARM: dts: OMAP4: Fix broken pbias device creation
>> > ARM: dts: OMAP5: Fix broken pbias device creation
>> > ARM: dts: dra7: Fix broken pbias device creation
>> >
>> > arch/arm/boot/dts/dra7.dtsi | 2 +-
>> > arch/arm/boot/dts/omap2430.dtsi | 3 ++-
>> > arch/arm/boot/dts/omap4.dtsi | 3 ++-
>> > arch/arm/boot/dts/omap5.dtsi | 3 ++-
>> > 4 files changed, 7 insertions(+), 4 deletions(-)
>> >
>>
>> For dra7-evm:
>> Tested-by: Grygorii Strashko <[email protected]>
>
> Applying all into omap-for-v4.2fixes-v2 thanks.

Do we need the same for am33xx.dtsi too given commit e3bc5358e097 ?

Peter

2015-08-07 14:26:50

by Kishon Vijay Abraham I

[permalink] [raw]
Subject: Re: [PATCH 0/4] omap: Fix broken pbias device creation

Hi Peter,

On Friday 07 August 2015 05:18 PM, Peter Robinson wrote:
> On Wed, Aug 5, 2015 at 11:00 AM, Tony Lindgren <[email protected]> wrote:
>> * Grygorii Strashko <[email protected]> [150729 02:01]:
>>> On 07/27/2015 03:16 PM, Kishon Vijay Abraham I wrote:
>>>> pbias device creation got broken once SCM cleanup got merged.
>>>> This patch series re-enables device creation by adding
>>>> "simple-bus" in the compatible property of the syscon
>>>> dt node.
>>>>
>>>> validated this series in DRA72, OMAP4 PANDA and OMAP5 UEVM
>>>> boards.
>>>>
>>>> Kishon Vijay Abraham I (4):
>>>> ARM: dts: omap24xx: Fix broken pbias device creation
>>>> ARM: dts: OMAP4: Fix broken pbias device creation
>>>> ARM: dts: OMAP5: Fix broken pbias device creation
>>>> ARM: dts: dra7: Fix broken pbias device creation
>>>>
>>>> arch/arm/boot/dts/dra7.dtsi | 2 +-
>>>> arch/arm/boot/dts/omap2430.dtsi | 3 ++-
>>>> arch/arm/boot/dts/omap4.dtsi | 3 ++-
>>>> arch/arm/boot/dts/omap5.dtsi | 3 ++-
>>>> 4 files changed, 7 insertions(+), 4 deletions(-)
>>>>
>>>
>>> For dra7-evm:
>>> Tested-by: Grygorii Strashko <[email protected]>
>>
>> Applying all into omap-for-v4.2fixes-v2 thanks.
>
> Do we need the same for am33xx.dtsi too given commit e3bc5358e097 ?

PBIAS is not present in am33xx.

Thanks
Kishon