2015-07-31 05:32:53

by Shraddha Barke

Subject: [PATCH] Staging : wilc1000 :Remove typedef from struct

This patch fixes the following checkpatch.pl warning:

WARNING: do not add new typedefs
Signed-off-by: Shraddha Barke <[email protected]>
---
drivers/staging/wilc1000/coreconfigurator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index 0f31d63..54eb8a1 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -140,7 +140,7 @@ typedef enum {
} tenuInfoElemID;


-typedef struct {
+struct {
char *pcRespBuffer;
s32 s32MaxRespBuffLen;
s32 s32BytesRead;
--
2.1.0

2015-07-31 05:46:08

by Joe Perches

Subject: Re: [PATCH] Staging : wilc1000 :Remove typedef from struct

On Fri, 2015-07-31 at 11:02 +0530, Shraddha Barke wrote:
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: do not add new typedefs
> Signed-off-by: Shraddha Barke <[email protected]>
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 0f31d63..54eb8a1 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -140,7 +140,7 @@ typedef enum {
> } tenuInfoElemID;
>
>
> -typedef struct {
> +struct {
> char *pcRespBuffer;
> s32 s32MaxRespBuffLen;
> s32 s32BytesRead;

You haven't compiled this.