2015-08-05 07:00:32

by Yuyang Du

Subject: [PATCH] vDSO,test: Add vdso_test as an additional target with add-assign

Simply adding the vdso_test target by removing the comment sign won't
work unless the targets are added correctly.

Signed-off-by: Yuyang Du <[email protected]>
---
Documentation/vDSO/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/vDSO/Makefile b/Documentation/vDSO/Makefile
index b12e987..6ea13ef 100644
--- a/Documentation/vDSO/Makefile
+++ b/Documentation/vDSO/Makefile
@@ -1,7 +1,7 @@
ifndef CROSS_COMPILE
-# vdso_test won't build for glibc < 2.16, so disable it
-# hostprogs-y := vdso_test
hostprogs-$(CONFIG_X86) := vdso_standalone_test_x86
+# vdso_test won't build for glibc < 2.16, so disable it
+# hostprogs-y += vdso_test
vdso_standalone_test_x86-objs := vdso_standalone_test_x86.o parse_vdso.o
vdso_test-objs := parse_vdso.o vdso_test.o

--
1.9.1

2015-08-05 18:26:45

by Andy Lutomirski

Subject: Re: [PATCH] vDSO,test: Add vdso_test as an additional target with add-assign

On Tue, Aug 4, 2015 at 4:09 PM, Yuyang Du <[email protected]> wrote:
> Simply adding the vdso_test target by removing the comment sign won't
> work unless the targets are added correctly.

Jon, is this yours or mine?

--Andy

>
> Signed-off-by: Yuyang Du <[email protected]>
> ---
> Documentation/vDSO/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/vDSO/Makefile b/Documentation/vDSO/Makefile
> index b12e987..6ea13ef 100644
> --- a/Documentation/vDSO/Makefile
> +++ b/Documentation/vDSO/Makefile
> @@ -1,7 +1,7 @@
> ifndef CROSS_COMPILE
> -# vdso_test won't build for glibc < 2.16, so disable it
> -# hostprogs-y := vdso_test
> hostprogs-$(CONFIG_X86) := vdso_standalone_test_x86
> +# vdso_test won't build for glibc < 2.16, so disable it
> +# hostprogs-y += vdso_test
> vdso_standalone_test_x86-objs := vdso_standalone_test_x86.o parse_vdso.o
> vdso_test-objs := parse_vdso.o vdso_test.o
>
> --
> 1.9.1
>



--
Andy Lutomirski
AMA Capital Management, LLC