2015-08-05 17:08:52

by Rabin Vincent

Subject: [PATCH] writeback: fix initial dirty limit

The initial value of global_wb_domain.dirty_limit set by
writeback_set_ratelimit() is zeroed out by the memset in
wb_domain_init().

Signed-off-by: Rabin Vincent <[email protected]>
---
mm/page-writeback.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 22cddd3..5cccc12 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -2063,10 +2063,10 @@ static struct notifier_block ratelimit_nb = {
*/
void __init page_writeback_init(void)
{
+ BUG_ON(wb_domain_init(&global_wb_domain, GFP_KERNEL));
+
writeback_set_ratelimit();
register_cpu_notifier(&ratelimit_nb);
-
- BUG_ON(wb_domain_init(&global_wb_domain, GFP_KERNEL));
}

/**
--
1.7.10.4

2015-08-05 17:19:10

by Tejun Heo

Subject: Re: [PATCH] writeback: fix initial dirty limit

On Wed, Aug 05, 2015 at 07:08:40PM +0200, Rabin Vincent wrote:
> The initial value of global_wb_domain.dirty_limit set by
> writeback_set_ratelimit() is zeroed out by the memset in
> wb_domain_init().
>
> Signed-off-by: Rabin Vincent <[email protected]>

Acked-by: Tejun Heo <[email protected]>

Thanks.

--
tejun