The previous versions of this patch contain spelling errors and cryptic messages, please ignore them. The patch removes the check of the return value of lzo1x_1_compress, since it returns always LZO_E_OK.
Salah Triki (1):
zram: Remove useless check
drivers/block/zram/zcomp_lzo.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--
1.9.1
lzo1x_1_compress always returns LZO_E_OK that is equal to 0. Thus, the
check of the return value is useless.
Signed-off-by: Salah Triki <[email protected]>
---
drivers/block/zram/zcomp_lzo.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/block/zram/zcomp_lzo.c b/drivers/block/zram/zcomp_lzo.c
index da1bc47..3cf30c9 100644
--- a/drivers/block/zram/zcomp_lzo.c
+++ b/drivers/block/zram/zcomp_lzo.c
@@ -26,8 +26,7 @@ static void lzo_destroy(void *private)
static int lzo_compress(const unsigned char *src, unsigned char *dst,
size_t *dst_len, void *private)
{
- int ret = lzo1x_1_compress(src, PAGE_SIZE, dst, dst_len, private);
- return ret == LZO_E_OK ? 0 : ret;
+ return lzo1x_1_compress(src, PAGE_SIZE, dst, dst_len, private);
}
static int lzo_decompress(const unsigned char *src, size_t src_len,
--
1.9.1
On (08/07/15 19:06), Salah Triki wrote:
> Date: Fri, 7 Aug 2015 19:06:42 +0100
> From: Salah Triki <[email protected]>
> To: [email protected], [email protected], [email protected]
> Cc: [email protected], [email protected]
> Subject: [PATCH V3 1/1] zram: Remove useless check
> X-Mailer: git-send-email 1.9.1
>
> lzo1x_1_compress always returns LZO_E_OK that is equal to 0. Thus, the
> check of the return value is useless.
>
> Signed-off-by: Salah Triki <[email protected]>
> ---
> drivers/block/zram/zcomp_lzo.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/zram/zcomp_lzo.c b/drivers/block/zram/zcomp_lzo.c
> index da1bc47..3cf30c9 100644
> --- a/drivers/block/zram/zcomp_lzo.c
> +++ b/drivers/block/zram/zcomp_lzo.c
> @@ -26,8 +26,7 @@ static void lzo_destroy(void *private)
> static int lzo_compress(const unsigned char *src, unsigned char *dst,
> size_t *dst_len, void *private)
> {
> - int ret = lzo1x_1_compress(src, PAGE_SIZE, dst, dst_len, private);
> - return ret == LZO_E_OK ? 0 : ret;
> + return lzo1x_1_compress(src, PAGE_SIZE, dst, dst_len, private);
> }
NACK. it may change someday, we don't control it.
the check must stay.
-ss