2015-08-13 00:01:41

by Gregory Fong

[permalink] [raw]
Subject: [PATCH] mm: cma: mark cma_bitmap_maxno() inline in header

cma_bitmap_maxno() was marked as static and not static inline, which
can cause warnings about this function not being used if this file is
included in a file that does not call that function, and violates the
conventions used elsewhere. The two options are to move the function
implementation back to mm/cma.c or make it inline here, and it's
simple enough for the latter to make sense.

Signed-off-by: Gregory Fong <[email protected]>
---
mm/cma.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/cma.h b/mm/cma.h
index 1132d73..17c75a4 100644
--- a/mm/cma.h
+++ b/mm/cma.h
@@ -16,7 +16,7 @@ struct cma {
extern struct cma cma_areas[MAX_CMA_AREAS];
extern unsigned cma_area_count;

-static unsigned long cma_bitmap_maxno(struct cma *cma)
+static inline unsigned long cma_bitmap_maxno(struct cma *cma)
{
return cma->count >> cma->order_per_bit;
}
--
1.9.1