2015-08-19 22:55:01

by Vivien Didelot

Subject: [PATCH net-next] net: dsa: mv88e6xxx: set 802.1Q mode to Fallback

The current Secure port mode requires the port-based VLANs to also be
valid in the 802.1Q VLAN Table Unit. The current hardware bridging
support only configures the port-based VLANs, thus is broken.

A new patchset is required to adapt the hardware bridging code to fully
support the Secure port mode.

In the meantime, change the 802.1Q mode of every ports to Fallback,
which filtering is more permissive, and doesn't add this restriction to
handle port-based and tagged-based VLANs.

Fixes: 8efdda4a1b60 ("net: dsa: mv88e6xxx: use port 802.1Q mode Secure")
Signed-off-by: Vivien Didelot <[email protected]>
---
drivers/net/dsa/mv88e6xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index dee71fa..91d7e0a 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -2091,7 +2091,7 @@ static int mv88e6xxx_setup_port(struct dsa_switch *ds, int port)
reg |= PORT_CONTROL_2_FORWARD_UNKNOWN;
}

- reg |= PORT_CONTROL_2_8021Q_SECURE;
+ reg |= PORT_CONTROL_2_8021Q_FALLBACK;

if (reg) {
ret = _mv88e6xxx_reg_write(ds, REG_PORT(port),
--
2.5.0

2015-08-23 22:54:55

by David Miller

Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: set 802.1Q mode to Fallback

From: Vivien Didelot <[email protected]>
Date: Wed, 19 Aug 2015 18:54:55 -0400

> The current Secure port mode requires the port-based VLANs to also be
> valid in the 802.1Q VLAN Table Unit. The current hardware bridging
> support only configures the port-based VLANs, thus is broken.
>
> A new patchset is required to adapt the hardware bridging code to fully
> support the Secure port mode.
>
> In the meantime, change the 802.1Q mode of every ports to Fallback,
> which filtering is more permissive, and doesn't add this restriction to
> handle port-based and tagged-based VLANs.
>
> Fixes: 8efdda4a1b60 ("net: dsa: mv88e6xxx: use port 802.1Q mode Secure")
> Signed-off-by: Vivien Didelot <[email protected]>

Applied, thanks.