Hi,
Being careless, judge the return value of snd_soc_card_jack_new
is opposite, so it should be fixed.
Thanks.
Changes in v1:
Signed-off-by: Xing Zheng <[email protected]>
Reviewed-by: Dylan Reid <[email protected]>
Xing Zheng (1):
ASoC: rockchip: fix a misjudgement by return
sound/soc/rockchip/rockchip_rt5645.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.7.9.5
Being careless, judge the return value of snd_soc_card_jack_new
is opposite, so it should be fixed.
---
Changes in v1:
Signed-off-by: Xing Zheng <[email protected]>
Reviewed-by: Dylan Reid <[email protected]>
sound/soc/rockchip/rockchip_rt5645.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/rockchip/rockchip_rt5645.c b/sound/soc/rockchip/rockchip_rt5645.c
index 3c6bb1e..adfe98c 100644
--- a/sound/soc/rockchip/rockchip_rt5645.c
+++ b/sound/soc/rockchip/rockchip_rt5645.c
@@ -118,7 +118,7 @@ static int rk_init(struct snd_soc_pcm_runtime *runtime)
SND_JACK_BTN_0 | SND_JACK_BTN_1 |
SND_JACK_BTN_2 | SND_JACK_BTN_3,
&headset_jack, NULL, 0);
- if (!ret) {
+ if (ret) {
dev_err(card->dev, "New Headset Jack failed! (%d)\n", ret);
return ret;
}
--
1.7.9.5
On Tue, Aug 25, 2015 at 03:52:41PM +0800, Xing Zheng wrote:
>
> Hi,
> Being careless, judge the return value of snd_soc_card_jack_new
> is opposite, so it should be fixed.
Please don't send cover letters for single patches, if there is anything
useful it should either be in the changelog or after the --- in the
patch.