2015-08-27 09:12:10

by Shilpasri G Bhat

Subject: [PATCH] cpufreq: powernv: Increase the verbosity of OCC console messages

Modify the OCC reset/load/active event message to make it clearer for
the user to understand the event and effect of the event.

Suggested-by: Stewart Smith <[email protected]>
Signed-off-by: Shilpasri G Bhat <[email protected]>
---
This patch is based on top of linux-next/master

drivers/cpufreq/powernv-cpufreq.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
index 546e056..64994e1 100644
--- a/drivers/cpufreq/powernv-cpufreq.c
+++ b/drivers/cpufreq/powernv-cpufreq.c
@@ -465,6 +465,7 @@ static int powernv_cpufreq_occ_msg(struct notifier_block *nb,
switch (omsg.type) {
case OCC_RESET:
occ_reset = true;
+ pr_info("OCC (On Chip Controller - enforces hard thermal/power limits) Resetting\n");
/*
* powernv_cpufreq_throttle_check() is called in
* target() callback which can detect the throttle state
@@ -474,12 +475,12 @@ static int powernv_cpufreq_occ_msg(struct notifier_block *nb,
*/
if (!throttled) {
throttled = true;
- pr_crit("CPU Frequency is throttled\n");
+ pr_crit("CPU frequency is throttled for duration\n");
}
- pr_info("OCC: Reset\n");
+
break;
case OCC_LOAD:
- pr_info("OCC: Loaded\n");
+ pr_info("OCC Loading, CPU frequency is throttled until OCC is started\n");
break;
case OCC_THROTTLE:
omsg.chip = be64_to_cpu(msg->params[1]);
@@ -488,7 +489,7 @@ static int powernv_cpufreq_occ_msg(struct notifier_block *nb,
if (occ_reset) {
occ_reset = false;
throttled = false;
- pr_info("OCC: Active\n");
+ pr_info("OCC Active, CPU frequency is no longer throttled\n");

for (i = 0; i < nr_chips; i++) {
chips[i].restore = true;
--
1.9.3

2015-08-27 12:29:46

by Viresh Kumar

Subject: Re: [PATCH] cpufreq: powernv: Increase the verbosity of OCC console messages

On 27-08-15, 14:41, Shilpasri G Bhat wrote:
> Modify the OCC reset/load/active event message to make it clearer for
> the user to understand the event and effect of the event.
>
> Suggested-by: Stewart Smith <[email protected]>
> Signed-off-by: Shilpasri G Bhat <[email protected]>
> ---
> This patch is based on top of linux-next/master
>
> drivers/cpufreq/powernv-cpufreq.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
> index 546e056..64994e1 100644
> --- a/drivers/cpufreq/powernv-cpufreq.c
> +++ b/drivers/cpufreq/powernv-cpufreq.c
> @@ -465,6 +465,7 @@ static int powernv_cpufreq_occ_msg(struct notifier_block *nb,
> switch (omsg.type) {
> case OCC_RESET:
> occ_reset = true;
> + pr_info("OCC (On Chip Controller - enforces hard thermal/power limits) Resetting\n");
> /*
> * powernv_cpufreq_throttle_check() is called in
> * target() callback which can detect the throttle state
> @@ -474,12 +475,12 @@ static int powernv_cpufreq_occ_msg(struct notifier_block *nb,
> */
> if (!throttled) {
> throttled = true;
> - pr_crit("CPU Frequency is throttled\n");
> + pr_crit("CPU frequency is throttled for duration\n");
> }
> - pr_info("OCC: Reset\n");
> +
> break;
> case OCC_LOAD:
> - pr_info("OCC: Loaded\n");
> + pr_info("OCC Loading, CPU frequency is throttled until OCC is started\n");
> break;
> case OCC_THROTTLE:
> omsg.chip = be64_to_cpu(msg->params[1]);
> @@ -488,7 +489,7 @@ static int powernv_cpufreq_occ_msg(struct notifier_block *nb,
> if (occ_reset) {
> occ_reset = false;
> throttled = false;
> - pr_info("OCC: Active\n");
> + pr_info("OCC Active, CPU frequency is no longer throttled\n");
>
> for (i = 0; i < nr_chips; i++) {
> chips[i].restore = true;

Acked-by: Viresh Kumar <[email protected]>

--
viresh

2015-08-31 21:39:19

by Stewart Smith

Subject: Re: [PATCH] cpufreq: powernv: Increase the verbosity of OCC console messages

Shilpasri G Bhat <[email protected]> writes:
> Modify the OCC reset/load/active event message to make it clearer for
> the user to understand the event and effect of the event.
>
> Suggested-by: Stewart Smith <[email protected]>
> Signed-off-by: Shilpasri G Bhat <[email protected]>

Acked-by: Stewart Smith <[email protected]>