2015-08-27 12:31:25

by Alexander Kuleshov

[permalink] [raw]
Subject: [PATCH] m68k/sun3: Use %pM format specifier to print ethernet address

printk() supports %pM format specifier for printing 6-byte MAC/FDDI
addresses in hex notation small buffers, let's use it intead of %x:%x...

Signed-off-by: Alexander Kuleshov <[email protected]>
---
arch/m68k/sun3/idprom.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/m68k/sun3/idprom.c b/arch/m68k/sun3/idprom.c
index c86ac37..cfe9aa4 100644
--- a/arch/m68k/sun3/idprom.c
+++ b/arch/m68k/sun3/idprom.c
@@ -125,8 +125,5 @@ void __init idprom_init(void)

display_system_type(idprom->id_machtype);

- printk("Ethernet address: %x:%x:%x:%x:%x:%x\n",
- idprom->id_ethaddr[0], idprom->id_ethaddr[1],
- idprom->id_ethaddr[2], idprom->id_ethaddr[3],
- idprom->id_ethaddr[4], idprom->id_ethaddr[5]);
+ printk("Ethernet address: %pM\n", idprom->id_ethaddr);
}
--
2.5.0


2015-08-27 12:41:01

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] m68k/sun3: Use %pM format specifier to print ethernet address

On Thu, Aug 27, 2015 at 2:30 PM, Alexander Kuleshov
<[email protected]> wrote:
> printk() supports %pM format specifier for printing 6-byte MAC/FDDI
> addresses in hex notation small buffers, let's use it intead of %x:%x...
>
> Signed-off-by: Alexander Kuleshov <[email protected]>

Thanks, will apply and queue for v4.4.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds