2015-08-27 17:41:21

by Bjorn Andersson

Subject: [PATCH] backlight: lp855x: Make sure props struct is zeroed

From: Werner Johansson <[email protected]>

The driver occasionally got stuck in suspend mode or other strange
states as those parts of the props struct were never initialized.

Signed-off-by: Werner Johansson <[email protected]>
Signed-off-by: Bjorn Andersson <[email protected]>
---
drivers/video/backlight/lp855x_bl.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index 88116b493f3b..0a7f88ce1ab0 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -282,6 +282,7 @@ static int lp855x_backlight_register(struct lp855x *lp)
struct lp855x_platform_data *pdata = lp->pdata;
const char *name = pdata->name ? : DEFAULT_BL_NAME;

+ memset(&props, 0, sizeof(props));
props.type = BACKLIGHT_PLATFORM;
props.max_brightness = MAX_BRIGHTNESS;

--
1.8.2.2

2015-08-27 22:44:30

by Kim, Milo

Subject: Re: [PATCH] backlight: lp855x: Make sure props struct is zeroed

On 8/28/2015 2:41 AM, Bjorn Andersson wrote:
> From: Werner Johansson <[email protected]>
>
> The driver occasionally got stuck in suspend mode or other strange
> states as those parts of the props struct were never initialized.

Acked-by: Milo Kim <[email protected]>

Thanks for catching this.

2015-08-27 22:51:42

by Johansson, Werner

Subject: RE: [PATCH] backlight: lp855x: Make sure props struct is zeroed

> > From: Werner Johansson <[email protected]>
> >
> > The driver occasionally got stuck in suspend mode or other strange
> > states as those parts of the props struct were never initialized.
>
> Acked-by: Milo Kim <[email protected]>
>
> Thanks for catching this.

You're most welcome! These issues can be difficult to track down, the stack is unpredictable..

/wj