2015-08-27 22:31:37

by Joe Stringer

[permalink] [raw]
Subject: [PATCH net-next 0/2] OPENVSWITCH && !NETFILTER build fix.

Fix issues reported by kbuild test robot:

All error/warnings (new ones prefixed by >>):

net/openvswitch/actions.c: In function 'ovs_fragment':
>> net/openvswitch/actions.c:705:16: error: implicit declaration of
function 'nf_get_ipv6_ops' [-Werror=implicit-function-declaration]
const struct nf_ipv6_ops *v6ops = nf_get_ipv6_ops();
^
>> net/openvswitch/actions.c:705:37: warning: initialization makes
pointer from integer without a cast
const struct nf_ipv6_ops *v6ops = nf_get_ipv6_ops();
^
>> net/openvswitch/actions.c:707:19: error: storage size of 'ovs_rt'
isn't known
struct rt6_info ovs_rt;
^
>> net/openvswitch/actions.c:724:8: error: dereferencing pointer to
incomplete type
v6ops->fragment(skb->sk, skb, ovs_vport_output);
^
>> net/openvswitch/actions.c:707:19: warning: unused variable 'ovs_rt'
[-Wunused-variable]
struct rt6_info ovs_rt;
^
cc1: some warnings being treated as errors

Joe Stringer (2):
netfilter: Define v6ops in !CONFIG_NETFILTER case.
openvswitch: Include ip6_fib.h.

include/linux/netfilter_ipv6.h | 18 +++++++++---------
net/openvswitch/actions.c | 1 +
2 files changed, 10 insertions(+), 9 deletions(-)

--
2.1.4


2015-08-27 22:32:09

by Joe Stringer

[permalink] [raw]
Subject: [PATCH net-next 1/2] netfilter: Define v6ops in !CONFIG_NETFILTER case.

When CONFIG_OPENVSWITCH is set, and CONFIG_NETFILTER is not set, the
openvswitch IPv6 fragmentation handling cannot refer to ipv6_ops because
it isn't defined. Add a dummy version to avoid #ifdefs in source files.

Fixes: 7f8a436 "openvswitch: Add conntrack action"
Signed-off-by: Joe Stringer <[email protected]>
---
include/linux/netfilter_ipv6.h | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/include/linux/netfilter_ipv6.h b/include/linux/netfilter_ipv6.h
index 8b7d28f..7715746 100644
--- a/include/linux/netfilter_ipv6.h
+++ b/include/linux/netfilter_ipv6.h
@@ -9,15 +9,6 @@

#include <uapi/linux/netfilter_ipv6.h>

-
-#ifdef CONFIG_NETFILTER
-int ip6_route_me_harder(struct sk_buff *skb);
-__sum16 nf_ip6_checksum(struct sk_buff *skb, unsigned int hook,
- unsigned int dataoff, u_int8_t protocol);
-
-int ipv6_netfilter_init(void);
-void ipv6_netfilter_fini(void);
-
/*
* Hook functions for ipv6 to allow xt_* modules to be built-in even
* if IPv6 is a module.
@@ -30,6 +21,14 @@ struct nf_ipv6_ops {
int (*output)(struct sock *, struct sk_buff *));
};

+#ifdef CONFIG_NETFILTER
+int ip6_route_me_harder(struct sk_buff *skb);
+__sum16 nf_ip6_checksum(struct sk_buff *skb, unsigned int hook,
+ unsigned int dataoff, u_int8_t protocol);
+
+int ipv6_netfilter_init(void);
+void ipv6_netfilter_fini(void);
+
extern const struct nf_ipv6_ops __rcu *nf_ipv6_ops;
static inline const struct nf_ipv6_ops *nf_get_ipv6_ops(void)
{
@@ -39,6 +38,7 @@ static inline const struct nf_ipv6_ops *nf_get_ipv6_ops(void)
#else /* CONFIG_NETFILTER */
static inline int ipv6_netfilter_init(void) { return 0; }
static inline void ipv6_netfilter_fini(void) { return; }
+static inline const struct nf_ipv6_ops *nf_get_ipv6_ops(void) { return NULL; }
#endif /* CONFIG_NETFILTER */

#endif /*__LINUX_IP6_NETFILTER_H*/
--
2.1.4

2015-08-27 22:31:46

by Joe Stringer

[permalink] [raw]
Subject: [PATCH net-next 2/2] openvswitch: Include ip6_fib.h.

kbuild test robot reports that certain configurations will not
automatically pick up on the "struct rt6_info" definition, so explicitly
include the header for this structure.

Fixes: 7f8a436 "openvswitch: Add conntrack action"
Signed-off-by: Joe Stringer <[email protected]>
---
net/openvswitch/actions.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
index 736a113..4487543 100644
--- a/net/openvswitch/actions.c
+++ b/net/openvswitch/actions.c
@@ -33,6 +33,7 @@
#include <net/dst.h>
#include <net/ip.h>
#include <net/ipv6.h>
+#include <net/ip6_fib.h>
#include <net/checksum.h>
#include <net/dsfield.h>
#include <net/mpls.h>
--
2.1.4

2015-08-27 23:36:09

by David Miller

[permalink] [raw]
Subject: Re: [PATCH net-next 0/2] OPENVSWITCH && !NETFILTER build fix.

From: Joe Stringer <[email protected]>
Date: Thu, 27 Aug 2015 15:25:44 -0700

> Fix issues reported by kbuild test robot:
>
> All error/warnings (new ones prefixed by >>):

Series applied, thanks.