2015-11-02 02:23:09

by Alexey Kardashevskiy

Subject: [PATCH kernel] rcu: Fix comment for rcu_dereference_raw_notrace

rcu_dereference_raw() calls indirectly rcu_read_lock_held() while
rcu_dereference_raw_notrace() does not so fix the comment about the latter.

Signed-off-by: Alexey Kardashevskiy <[email protected]>
---
include/linux/rcupdate.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
index 581abf8..931d627 100644
--- a/include/linux/rcupdate.h
+++ b/include/linux/rcupdate.h
@@ -760,7 +760,7 @@ static inline void rcu_preempt_sleep_check(void)
* The tracing infrastructure traces RCU (we want that), but unfortunately
* some of the RCU checks causes tracing to lock up the system.
*
- * The tracing version of rcu_dereference_raw() must not call
+ * The no-tracing version of rcu_dereference_raw() must not call
* rcu_read_lock_held().
*/
#define rcu_dereference_raw_notrace(p) __rcu_dereference_check((p), 1, __rcu)
--
2.5.0.rc3

2015-11-02 03:15:25

by Paul E. McKenney

Subject: Re: [PATCH kernel] rcu: Fix comment for rcu_dereference_raw_notrace

On Mon, Nov 02, 2015 at 01:21:47PM +1100, Alexey Kardashevskiy wrote:
> rcu_dereference_raw() calls indirectly rcu_read_lock_held() while
> rcu_dereference_raw_notrace() does not so fix the comment about the latter.
>
> Signed-off-by: Alexey Kardashevskiy <[email protected]>

Good eyes! Queued for 4.5, thank you!

Thanx, Paul

> ---
> include/linux/rcupdate.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
> index 581abf8..931d627 100644
> --- a/include/linux/rcupdate.h
> +++ b/include/linux/rcupdate.h
> @@ -760,7 +760,7 @@ static inline void rcu_preempt_sleep_check(void)
> * The tracing infrastructure traces RCU (we want that), but unfortunately
> * some of the RCU checks causes tracing to lock up the system.
> *
> - * The tracing version of rcu_dereference_raw() must not call
> + * The no-tracing version of rcu_dereference_raw() must not call
> * rcu_read_lock_held().
> */
> #define rcu_dereference_raw_notrace(p) __rcu_dereference_check((p), 1, __rcu)
> --
> 2.5.0.rc3
>