2015-11-05 23:43:05

by Andrew Duggan

Subject: [PATCH 24/26] Input: synaptics-rmi4: use device managed memory for the data packet buffer

The data packet should use device managed memory since the buffer is
retained until the device goes away.

Signed-off-by: Andrew Duggan <[email protected]>
---
drivers/input/rmi4/rmi_f11.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
index ee4b155..10a0c11 100644
--- a/drivers/input/rmi4/rmi_f11.c
+++ b/drivers/input/rmi4/rmi_f11.c
@@ -683,7 +683,8 @@ static int f11_2d_construct_data(struct f11_data *f11)
sensor->pkt_size +=
DIV_ROUND_UP(query->nr_touch_shapes + 1, 8);

- sensor->data_pkt = kzalloc(sensor->pkt_size, GFP_KERNEL);
+ sensor->data_pkt = devm_kzalloc(&sensor->fn->dev, sensor->pkt_size,
+ GFP_KERNEL);
if (!sensor->data_pkt)
return -ENOMEM;

--
2.1.4

2015-11-09 13:35:26

by Linus Walleij

Subject: Re: [PATCH 24/26] Input: synaptics-rmi4: use device managed memory for the data packet buffer

On Fri, Nov 6, 2015 at 12:42 AM, Andrew Duggan <[email protected]> wrote:

> The data packet should use device managed memory since the buffer is
> retained until the device goes away.
>
> Signed-off-by: Andrew Duggan <[email protected]>

Squash into F11 patch.

Acked-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij