When compiled as a module we get a tainted kernel because of the lack
of the module information and the following errors. Add details to
fix the issue when wm8994_irq/wm8994_regmap are modular.
wm8994_irq: module license 'unspecified' taints kernel.
wm8994_irq: Unknown symbol irq_domain_xlate_twocell (err 0)
wm8994_irq: Unknown symbol regmap_write (err 0)
wm8994_irq: Unknown symbol gpiod_to_irq (err 0)
wm8994_irq: Unknown symbol irq_modify_status (err 0)
wm8994_irq: Unknown symbol irq_set_chip_and_handler_name (err 0)
wm8994_irq: Unknown symbol regmap_add_irq_chip (err 0)
wm8994_irq: Unknown symbol gpiod_get_raw_value_cansleep (err 0)
wm8994_irq: Unknown symbol handle_nested_irq (err 0)
wm8994_irq: Unknown symbol __irq_domain_add (err 0)
wm8994_irq: Unknown symbol irq_create_mapping (err 0)
wm8994_irq: Unknown symbol gpio_to_desc (err 0)
wm8994_irq: Unknown symbol regmap_del_irq_chip (err 0)
wm8994_regmap: module license 'unspecified' taints kernel.
Cc: <[email protected]>
Signed-off-by: Peter Robinson <[email protected]>
---
drivers/mfd/wm8994-irq.c | 5 +++++
drivers/mfd/wm8994-regmap.c | 5 +++++
2 files changed, 10 insertions(+)
diff --git a/drivers/mfd/wm8994-irq.c b/drivers/mfd/wm8994-irq.c
index 18710f3..5538521 100644
--- a/drivers/mfd/wm8994-irq.c
+++ b/drivers/mfd/wm8994-irq.c
@@ -262,3 +262,8 @@ void wm8994_irq_exit(struct wm8994 *wm8994)
regmap_del_irq_chip(wm8994->irq, wm8994->irq_data);
}
EXPORT_SYMBOL(wm8994_irq_exit);
+
+MODULE_DESCRIPTION("WM8994 interrupt controller");
+MODULE_AUTHOR("Mark Brown <[email protected]>");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:wm8994-irq");
diff --git a/drivers/mfd/wm8994-regmap.c b/drivers/mfd/wm8994-regmap.c
index c56b160..16b3e75 100644
--- a/drivers/mfd/wm8994-regmap.c
+++ b/drivers/mfd/wm8994-regmap.c
@@ -1289,3 +1289,8 @@ struct regmap_config wm8994_base_regmap_config = {
.val_bits = 16,
};
EXPORT_SYMBOL(wm8994_base_regmap_config);
+
+MODULE_DESCRIPTION("WM8994 Register mapping data");
+MODULE_AUTHOR("Mark Brown <[email protected]>");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:wm8994-regmap");
--
2.5.0
Hi Peter,
[auto build test ERROR on: ljones-mfd/for-mfd-next]
[also build test ERROR on: v4.3 next-20151106]
url: https://github.com/0day-ci/linux/commits/Peter-Robinson/mfd-wm8994-Add-module-description-author-license-information/20151107-203151
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: x86_64-randconfig-i0-11072104 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/mfd/wm8994-regmap.c:1293:20: error: expected declaration specifiers or '...' before string constant
MODULE_DESCRIPTION("WM8994 Register mapping data");
^
drivers/mfd/wm8994-regmap.c:1294:15: error: expected declaration specifiers or '...' before string constant
MODULE_AUTHOR("Mark Brown <[email protected]>");
^
drivers/mfd/wm8994-regmap.c:1295:16: error: expected declaration specifiers or '...' before string constant
MODULE_LICENSE("GPL v2");
^
drivers/mfd/wm8994-regmap.c:1296:14: error: expected declaration specifiers or '...' before string constant
MODULE_ALIAS("platform:wm8994-regmap");
^
vim +1293 drivers/mfd/wm8994-regmap.c
1287 struct regmap_config wm8994_base_regmap_config = {
1288 .reg_bits = 16,
1289 .val_bits = 16,
1290 };
1291 EXPORT_SYMBOL(wm8994_base_regmap_config);
1292
> 1293 MODULE_DESCRIPTION("WM8994 Register mapping data");
1294 MODULE_AUTHOR("Mark Brown <[email protected]>");
1295 MODULE_LICENSE("GPL v2");
1296 MODULE_ALIAS("platform:wm8994-regmap");
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation