2015-11-09 12:51:20

by Nizam Haider

Subject: [PATCH] iio: adc: ad7793: removed unnecessary else.

Else is not generally useful after a break or return.

Signed-off-by: Nizam Haider <[email protected]>
---
drivers/iio/adc/ad7793.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
index eea0c79..3bc5655 100644
--- a/drivers/iio/adc/ad7793.c
+++ b/drivers/iio/adc/ad7793.c
@@ -478,10 +478,9 @@ static int ad7793_read_raw(struct iio_dev *indio_dev,
*val2 = st->
scale_avail[(st->conf >> 8) & 0x7][1];
return IIO_VAL_INT_PLUS_NANO;
- } else {
- /* 1170mV / 2^23 * 6 */
- scale_uv = (1170ULL * 1000000000ULL * 6ULL);
}
+ /* 1170mV / 2^23 * 6 */
+ scale_uv = (1170ULL * 1000000000ULL * 6ULL);
break;
case IIO_TEMP:
/* 1170mV / 0.81 mV/C / 2^23 */
--
1.8.1.4

2015-11-15 11:14:47

by Jonathan Cameron

Subject: Re: [PATCH] iio: adc: ad7793: removed unnecessary else.

On 09/11/15 12:50, Nizam Haider wrote:
> Else is not generally useful after a break or return.
>
> Signed-off-by: Nizam Haider <[email protected]>
Applied, thanks.

Jonathan
> ---
> drivers/iio/adc/ad7793.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
> index eea0c79..3bc5655 100644
> --- a/drivers/iio/adc/ad7793.c
> +++ b/drivers/iio/adc/ad7793.c
> @@ -478,10 +478,9 @@ static int ad7793_read_raw(struct iio_dev *indio_dev,
> *val2 = st->
> scale_avail[(st->conf >> 8) & 0x7][1];
> return IIO_VAL_INT_PLUS_NANO;
> - } else {
> - /* 1170mV / 2^23 * 6 */
> - scale_uv = (1170ULL * 1000000000ULL * 6ULL);
> }
> + /* 1170mV / 2^23 * 6 */
> + scale_uv = (1170ULL * 1000000000ULL * 6ULL);
> break;
> case IIO_TEMP:
> /* 1170mV / 0.81 mV/C / 2^23 */
>