2015-11-09 17:45:04

by Ranjith Thangavel

Subject: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

BIT macro is used for defining BIT location instead of
shifting operator - coding style issue

Signed-off-by: Ranjith T <[email protected]>
---
drivers/staging/comedi/drivers/comedi_parport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
index 15a4093..1bf8ddc 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -75,8 +75,8 @@
#define PARPORT_DATA_REG 0x00
#define PARPORT_STATUS_REG 0x01
#define PARPORT_CTRL_REG 0x02
-#define PARPORT_CTRL_IRQ_ENA (1 << 4)
-#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
+#define PARPORT_CTRL_IRQ_ENA BIT(4)
+#define PARPORT_CTRL_BIDIR_ENA BIT(5)

static int parport_data_reg_insn_bits(struct comedi_device *dev,
struct comedi_subdevice *s,
--
1.7.10.4

2015-11-11 13:44:09

by Ranjith Thangavel

Subject: Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

Is this patch is fine?.

Thanks,
Ranjith T.

On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T <[email protected]> wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith T <[email protected]>
> ---
> drivers/staging/comedi/drivers/comedi_parport.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
> index 15a4093..1bf8ddc 100644
> --- a/drivers/staging/comedi/drivers/comedi_parport.c
> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
> @@ -75,8 +75,8 @@
> #define PARPORT_DATA_REG 0x00
> #define PARPORT_STATUS_REG 0x01
> #define PARPORT_CTRL_REG 0x02
> -#define PARPORT_CTRL_IRQ_ENA (1 << 4)
> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
> +#define PARPORT_CTRL_IRQ_ENA BIT(4)
> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>
> static int parport_data_reg_insn_bits(struct comedi_device *dev,
> struct comedi_subdevice *s,
> --
> 1.7.10.4

2015-11-11 14:11:54

by Ian Abbott

Subject: Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

On 11/11/2015 13:44, Ranjith T wrote:
> Is this patch is fine?.
>
> Thanks,
> Ranjith T.

Fine apart from the "Signed-off-by" line. I'm guessing your last name
isn't really "T".

> On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T <[email protected]> wrote:
>> BIT macro is used for defining BIT location instead of
>> shifting operator - coding style issue
>>
>> Signed-off-by: Ranjith T <[email protected]>
>> ---
>> drivers/staging/comedi/drivers/comedi_parport.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
>> index 15a4093..1bf8ddc 100644
>> --- a/drivers/staging/comedi/drivers/comedi_parport.c
>> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
>> @@ -75,8 +75,8 @@
>> #define PARPORT_DATA_REG 0x00
>> #define PARPORT_STATUS_REG 0x01
>> #define PARPORT_CTRL_REG 0x02
>> -#define PARPORT_CTRL_IRQ_ENA (1 << 4)
>> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
>> +#define PARPORT_CTRL_IRQ_ENA BIT(4)
>> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>>
>> static int parport_data_reg_insn_bits(struct comedi_device *dev,
>> struct comedi_subdevice *s,
>> --
>> 1.7.10.4

--
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
-=( Web: http://www.mev.co.uk/ )=-

2015-11-11 14:18:22

by Ranjith Thangavel

Subject: Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

Actually my name is Ranjith and father name is Thangavel. So I used to
mention my name as Ranjith T.


Thanks,
Ranjith T

On Wed, Nov 11, 2015 at 7:41 PM, Ian Abbott <[email protected]> wrote:
> On 11/11/2015 13:44, Ranjith T wrote:
>>
>> Is this patch is fine?.
>>
>> Thanks,
>> Ranjith T.
>
>
> Fine apart from the "Signed-off-by" line. I'm guessing your last name isn't
> really "T".
>
>
>> On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T <[email protected]> wrote:
>>>
>>> BIT macro is used for defining BIT location instead of
>>> shifting operator - coding style issue
>>>
>>> Signed-off-by: Ranjith T <[email protected]>
>>> ---
>>> drivers/staging/comedi/drivers/comedi_parport.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c
>>> b/drivers/staging/comedi/drivers/comedi_parport.c
>>> index 15a4093..1bf8ddc 100644
>>> --- a/drivers/staging/comedi/drivers/comedi_parport.c
>>> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
>>> @@ -75,8 +75,8 @@
>>> #define PARPORT_DATA_REG 0x00
>>> #define PARPORT_STATUS_REG 0x01
>>> #define PARPORT_CTRL_REG 0x02
>>> -#define PARPORT_CTRL_IRQ_ENA (1 << 4)
>>> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
>>> +#define PARPORT_CTRL_IRQ_ENA BIT(4)
>>> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>>>
>>> static int parport_data_reg_insn_bits(struct comedi_device *dev,
>>> struct comedi_subdevice *s,
>>> --
>>> 1.7.10.4
>
>
> --
> -=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
> -=( Web: http://www.mev.co.uk/ )=-

2015-11-11 14:36:52

by Ian Abbott

Subject: Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

On 11/11/15 14:18, Ranjith T wrote:
> Actually my name is Ranjith and father name is Thangavel. So I used to
> mention my name as Ranjith T.

How do you write your name on legal documents? That is what you should
use on the patch's "Signed-off-by:" line, and on the email's "From:" line.

Thanks.

--
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
-=( Web: http://www.mev.co.uk/ )=-