2015-11-10 04:17:25

by Al Viro

Subject: Re: [PATCH v4 03/11] lsm: add file opener's cred to a setprocattr arguments

On Wed, Oct 14, 2015 at 02:41:57PM +0200, Lukasz Pawelczyk wrote:
> int (*getprocattr)(struct task_struct *p, char *name, char **value);
> - int (*setprocattr)(struct task_struct *p, char *name, void *value,
> - size_t size);
> + int (*setprocattr)(struct task_struct *p, const struct cred *f_cred,
> + char *name, void *value, size_t size);

*grumble*

Why the hell is that thing taking char *name - not even const char *?

2015-11-10 10:15:15

by Lukasz Pawelczyk

Subject: Re: [PATCH v4 03/11] lsm: add file opener's cred to a setprocattr arguments

On wto, 2015-11-10 at 04:16 +0000, Al Viro wrote:
> On Wed, Oct 14, 2015 at 02:41:57PM +0200, Lukasz Pawelczyk wrote:
> > int (*getprocattr)(struct task_struct *p, char *name, char
> > **value);
> > - int (*setprocattr)(struct task_struct *p, char *name, void
> > *value,
> > - size_t size);
> > + int (*setprocattr)(struct task_struct *p, const struct
> > cred *f_cred,
> > + char *name, void *value, size_t size);
>
> *grumble*
>
> Why the hell is that thing taking char *name - not even const char *?

I was wondering that myself. But as this is unrelated I decided not to
change it. Do you want me to while at it?




--