2015-11-11 16:24:13

by Ranjith Thangavel

Subject: [PATCH] comedi: cb_pcidda: Fix coding style - use BIT macro

BIT macro is used for defining BIT location instead of
shifting operator - coding style issue

Signed-off-by: Ranjith Thangavel <[email protected]>
---
drivers/staging/comedi/drivers/cb_pcidda.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/comedi/drivers/cb_pcidda.c b/drivers/staging/comedi/drivers/cb_pcidda.c
index b00a36a..ccb37d1 100644
--- a/drivers/staging/comedi/drivers/cb_pcidda.c
+++ b/drivers/staging/comedi/drivers/cb_pcidda.c
@@ -51,13 +51,13 @@

/* DAC registers */
#define CB_DDA_DA_CTRL_REG 0x00 /* D/A Control Register */
-#define CB_DDA_DA_CTRL_SU (1 << 0) /* Simultaneous update */
-#define CB_DDA_DA_CTRL_EN (1 << 1) /* Enable specified DAC */
+#define CB_DDA_DA_CTRL_SU BIT(0) /* Simultaneous update */
+#define CB_DDA_DA_CTRL_EN BIT(1) /* Enable specified DAC */
#define CB_DDA_DA_CTRL_DAC(x) ((x) << 2) /* Specify DAC channel */
#define CB_DDA_DA_CTRL_RANGE2V5 (0 << 6) /* 2.5V range */
#define CB_DDA_DA_CTRL_RANGE5V (2 << 6) /* 5V range */
#define CB_DDA_DA_CTRL_RANGE10V (3 << 6) /* 10V range */
-#define CB_DDA_DA_CTRL_UNIP (1 << 8) /* Unipolar range */
+#define CB_DDA_DA_CTRL_UNIP BIT(8) /* Unipolar range */

#define DACALIBRATION1 4 /* D/A CALIBRATION REGISTER 1 */
/* write bits */
--
1.7.10.4

2015-11-12 18:02:14

by Ian Abbott

Subject: Re: [PATCH] comedi: cb_pcidda: Fix coding style - use BIT macro

On 11/11/15 16:27, Ranjith Thangavel wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith Thangavel <[email protected]>
> ---
> drivers/staging/comedi/drivers/cb_pcidda.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidda.c b/drivers/staging/comedi/drivers/cb_pcidda.c
> index b00a36a..ccb37d1 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidda.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidda.c
> @@ -51,13 +51,13 @@
>
> /* DAC registers */
> #define CB_DDA_DA_CTRL_REG 0x00 /* D/A Control Register */
> -#define CB_DDA_DA_CTRL_SU (1 << 0) /* Simultaneous update */
> -#define CB_DDA_DA_CTRL_EN (1 << 1) /* Enable specified DAC */
> +#define CB_DDA_DA_CTRL_SU BIT(0) /* Simultaneous update */
> +#define CB_DDA_DA_CTRL_EN BIT(1) /* Enable specified DAC */
> #define CB_DDA_DA_CTRL_DAC(x) ((x) << 2) /* Specify DAC channel */
> #define CB_DDA_DA_CTRL_RANGE2V5 (0 << 6) /* 2.5V range */
> #define CB_DDA_DA_CTRL_RANGE5V (2 << 6) /* 5V range */
> #define CB_DDA_DA_CTRL_RANGE10V (3 << 6) /* 10V range */
> -#define CB_DDA_DA_CTRL_UNIP (1 << 8) /* Unipolar range */
> +#define CB_DDA_DA_CTRL_UNIP BIT(8) /* Unipolar range */
>
> #define DACALIBRATION1 4 /* D/A CALIBRATION REGISTER 1 */
> /* write bits */
>

Thanks!

Reviewed-by: Ian Abbott <[email protected]>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
-=( Web: http://www.mev.co.uk/ )=-

2015-11-12 18:09:38

by Fabio Estevam

Subject: Re: [PATCH] comedi: cb_pcidda: Fix coding style - use BIT macro

On Wed, Nov 11, 2015 at 2:27 PM, Ranjith Thangavel
<[email protected]> wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue

I would not call it a coding style issue.