2015-11-12 18:58:34

by Matias Bjørling

[permalink] [raw]
Subject: [PATCH v2] lightnvm: change max_phys_sect to ushort

The max_phys_sect variable is defined as a char. We do a boundary check
to maximally allow 256 physical page descriptors per command. As we are
not indexing from zero. This expression is always in false. Bump the
max_phys_sect to an unsigned short to support the range chech.

Signed-off-by: Matias Bjørling <[email protected]>
Reported-by: Geert Uytterhoeven <[email protected]>
---
include/linux/lightnvm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h
index 69c9057..e8bc52a 100644
--- a/include/linux/lightnvm.h
+++ b/include/linux/lightnvm.h
@@ -220,7 +220,7 @@ struct nvm_dev_ops {
nvm_dev_dma_alloc_fn *dev_dma_alloc;
nvm_dev_dma_free_fn *dev_dma_free;

- uint8_t max_phys_sect;
+ unsigned short max_phys_sect;
};

struct nvm_lun {
--
2.1.4