Hello Linus,
Apologies for the late PULL request.
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next
This series contains HCH's changes to absorb configfs attribute ->show()
+ ->store() function pointer usage from it's original tree-wide
consumers, into common configfs code.
It includes usb-gadget, target w/ drivers, netconsole and ocfs2 changes
to realize the improved simplicity, that now renders the original
include/target/configfs_macros.h CPP magic for fabric drivers and
others, unnecessary and obsolete.
And with common code in place, new configfs attributes can be added
easier than ever before.
Note, there are further improvements in-flight from other folks for v4.5
code in configfs land, plus number of target fixes for post -rc1 code.
Thank you,
--nab
Christoph Hellwig (23):
configfs: add show and store methods to struct configfs_attribute
usb-gadget: use per-attribute show and store methods
usb-gadget/uvc: use per-attribute show and store methods
usb-gadget/f_hid: use per-attribute show and store methods
usb-gadget/f_acm: use per-attribute show and store methods
usb-gadget/ether: use per-attribute show and store methods
usb-gadget/f_loopback: use per-attribute show and store methods
usb-gadget/f_midi: use per-attribute show and store methods
usb-gadget/f_printer: use per-attribute show and store methods
usb-gadget/f_sourcesink: use per-attribute show and store methods
usb-gadget/f_mass_storage: use per-attribute show and store methods
usb-gadget/f_uac1: use per-attribute show and store methods
usb-gadget/f_uac2: use per-attribute show and store methods
usb-gadget/f_obex: use per-attribute show and store methods
usb-gadget/f_phonet: use per-attribute show and store methods
usb-gadget/f_serial: use per-attribute show and store methods
dlm: use per-attribute show and store methods
spear13xx_pcie_gadget: use per-attribute show and store methods
target: use per-attribute show and store methods
netconsole: use per-attribute show and store methods
ocfs2/cluster: move locking into attribute store methods
ocfs2/cluster: use per-attribute show and store methods
configfs: remove old API
Documentation/filesystems/Makefile | 2 -
Documentation/filesystems/configfs/Makefile | 3 -
Documentation/filesystems/configfs/configfs.txt | 38 +-
.../configfs/configfs_example_explicit.c | 483 --------
Documentation/target/tcm_mod_builder.py | 17 -
drivers/infiniband/ulp/srpt/ib_srpt.c | 78 +-
drivers/misc/spear13xx_pcie_gadget.c | 216 ++--
drivers/net/netconsole.c | 271 +++--
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 153 +--
drivers/target/iscsi/iscsi_target_configfs.c | 791 +++++--------
drivers/target/iscsi/iscsi_target_stat.c | 666 +++++------
drivers/target/loopback/tcm_loop.c | 60 +-
drivers/target/sbp/sbp_target.c | 87 +-
drivers/target/target_core_configfs.c | 1209 +++++++-------------
drivers/target/target_core_fabric_configfs.c | 275 ++---
drivers/target/target_core_internal.h | 3 +
drivers/target/target_core_stat.c | 918 ++++++---------
drivers/target/tcm_fc/tfc_cmd.c | 1 -
drivers/target/tcm_fc/tfc_conf.c | 44 +-
drivers/target/tcm_fc/tfc_io.c | 1 -
drivers/target/tcm_fc/tfc_sess.c | 1 -
drivers/usb/gadget/configfs.c | 295 ++---
drivers/usb/gadget/function/f_acm.c | 26 +-
drivers/usb/gadget/function/f_ecm.c | 8 +-
drivers/usb/gadget/function/f_eem.c | 8 +-
drivers/usb/gadget/function/f_hid.c | 34 +-
drivers/usb/gadget/function/f_loopback.c | 31 +-
drivers/usb/gadget/function/f_mass_storage.c | 119 +-
drivers/usb/gadget/function/f_midi.c | 37 +-
drivers/usb/gadget/function/f_ncm.c | 8 +-
drivers/usb/gadget/function/f_obex.c | 26 +-
drivers/usb/gadget/function/f_phonet.c | 25 +-
drivers/usb/gadget/function/f_printer.c | 30 +-
drivers/usb/gadget/function/f_rndis.c | 8 +-
drivers/usb/gadget/function/f_serial.c | 26 +-
drivers/usb/gadget/function/f_sourcesink.c | 83 +-
drivers/usb/gadget/function/f_subset.c | 8 +-
drivers/usb/gadget/function/f_uac1.c | 39 +-
drivers/usb/gadget/function/f_uac2.c | 28 +-
drivers/usb/gadget/function/u_ether_configfs.h | 44 +-
drivers/usb/gadget/function/uvc_configfs.c | 387 +++----
drivers/usb/gadget/legacy/tcm_usb_gadget.c | 44 +-
drivers/vhost/scsi.c | 41 +-
drivers/xen/xen-scsiback.c | 32 +-
fs/configfs/file.c | 12 +-
fs/dlm/config.c | 288 ++---
fs/ocfs2/cluster/heartbeat.c | 205 +---
fs/ocfs2/cluster/nodemanager.c | 281 ++---
include/linux/configfs.h | 97 +-
include/linux/usb/gadget_configfs.h | 19 +-
include/target/configfs_macros.h | 147 ---
include/target/target_core_base.h | 60 +
include/target/target_core_fabric_configfs.h | 122 --
samples/Kconfig | 6 +
samples/Makefile | 3 +-
samples/configfs/Makefile | 2 +
.../configfs/configfs_sample.c | 140 +--
57 files changed, 2652 insertions(+), 5434 deletions(-)
delete mode 100644 Documentation/filesystems/configfs/Makefile
delete mode 100644 Documentation/filesystems/configfs/configfs_example_explicit.c
delete mode 100644 include/target/configfs_macros.h
delete mode 100644 include/target/target_core_fabric_configfs.h
create mode 100644 samples/configfs/Makefile
rename Documentation/filesystems/configfs/configfs_example_macros.c => samples/configfs/configfs_sample.c (74%)
On 11/13/2015 02:00 AM, Nicholas A. Bellinger wrote:
> Hello Linus,
>
> Apologies for the late PULL request.
>
> Please pull from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next
>
> This series contains HCH's changes to absorb configfs attribute ->show()
> + ->store() function pointer usage from it's original tree-wide
> consumers, into common configfs code.
>
> It includes usb-gadget, target w/ drivers, netconsole and ocfs2 changes
> to realize the improved simplicity, that now renders the original
> include/target/configfs_macros.h CPP magic for fabric drivers and
> others, unnecessary and obsolete.
>
> And with common code in place, new configfs attributes can be added
> easier than ever before.
>
> Note, there are further improvements in-flight from other folks for v4.5
> code in configfs land, plus number of target fixes for post -rc1 code.
Hello Nic,
Although the first version of my patch series that makes ABORT and LUN
RESET handling synchronous was posted six months ago, although this
patch series significantly improves reliability of the target core and
also improves source code readability and although the entire patch
series has received positive reviews from three experienced kernel
developers I am still waiting for feedback from you about the technical
aspects of these patches. You are the maintainer of the in-tree SCSI
target subsystem so it is your role to provide feedback on patches for
this subsystem.
The patch series I am referring to is "SCSI target patches for kernel
v4.4" (http://thread.gmane.org/gmane.linux.scsi.target.devel/10365).
Bart.
What the hell is wrong with linux-scsi.org?
Your machine:
Date: Fri, 13 Nov 2015 02:00:11 -0800
linux-iscsi.org:
Received: from [192.168.1.69] ...
by linux-iscsi.org (Postfix) with ESMTPSA id 80B6822DA37;
Fri, 13 Nov 2015 09:55:48 +0000 (UTC)
mx.google.com:
Received: from linux-iscsi.org ...
Fri, 13 Nov 2015 02:00:23 -0800 (PST)
That stupid server clock is off by over four *minutes*. Notice the
jump back from just after the hour, to almost five minutes before the
hour?
Please get it some maintenance love. I'm OCD when it comes to
timekeeping, and something on the internet being off by four minutes
just makes me go "Eww".
ntp was invented, what, 35 years ago?
Linus