2015-11-13 20:22:01

by Nizam Haider

Subject: [PATCH] Rtc: rtc-gemini.c: Remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release
or on probe failure

Signed-off-by: Nizam Haider <[email protected]>
---
drivers/rtc/rtc-gemini.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-gemini.c b/drivers/rtc/rtc-gemini.c
index e841846..f46b6d4 100644
--- a/drivers/rtc/rtc-gemini.c
+++ b/drivers/rtc/rtc-gemini.c
@@ -156,7 +156,6 @@ static int gemini_rtc_remove(struct platform_device *pdev)
struct gemini_rtc *rtc = platform_get_drvdata(pdev);

rtc_device_unregister(rtc->rtc_dev);
- platform_set_drvdata(pdev, NULL);

return 0;
}
--
1.8.1.4

2015-11-15 10:57:14

by Hans Ulli Kroll

Subject: Re: [PATCH] Rtc: rtc-gemini.c: Remove unnecessary platform_set_drvdata()

On Sat, 14 Nov 2015, Nizam Haider wrote:

> The driver core clears the driver data to NULL after device_release
> or on probe failure
>
> Signed-off-by: Nizam Haider <[email protected]>
> ---
> drivers/rtc/rtc-gemini.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-gemini.c b/drivers/rtc/rtc-gemini.c
> index e841846..f46b6d4 100644
> --- a/drivers/rtc/rtc-gemini.c
> +++ b/drivers/rtc/rtc-gemini.c
> @@ -156,7 +156,6 @@ static int gemini_rtc_remove(struct platform_device *pdev)
> struct gemini_rtc *rtc = platform_get_drvdata(pdev);
>
> rtc_device_unregister(rtc->rtc_dev);
> - platform_set_drvdata(pdev, NULL);
>
> return 0;
> }
> --
> 1.8.1.4
>
>

Acked-by: Hans Ulli Kroll <[email protected]>

2015-11-30 19:04:14

by Alexandre Belloni

Subject: Re: [PATCH] Rtc: rtc-gemini.c: Remove unnecessary platform_set_drvdata()

On 14/11/2015 at 01:51:29 +0530, Nizam Haider wrote :
> The driver core clears the driver data to NULL after device_release
> or on probe failure
>
> Signed-off-by: Nizam Haider <[email protected]>
> ---
> drivers/rtc/rtc-gemini.c | 1 -
> 1 file changed, 1 deletion(-)
>
Applied, thanks.

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com