2015-11-15 23:12:26

by Nizam Haider

Subject: [PATCH] IIO: adc: xilinx-xadc-core.c: constify iio_buffer_setup_ops structure

structure iio_buffer_setup_ops is never modified, so declare it as const.

Signed-off-by: Nizam Haider <[email protected]>
---
drivers/iio/adc/xilinx-xadc-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
index 0370624..c2b5f10 100644
--- a/drivers/iio/adc/xilinx-xadc-core.c
+++ b/drivers/iio/adc/xilinx-xadc-core.c
@@ -803,7 +803,7 @@ err:
return ret;
}

-static struct iio_buffer_setup_ops xadc_buffer_ops = {
+static const struct iio_buffer_setup_ops xadc_buffer_ops = {
.preenable = &xadc_preenable,
.postenable = &iio_triggered_buffer_postenable,
.predisable = &iio_triggered_buffer_predisable,
--
1.8.1.4

2015-11-16 06:55:17

by Jonathan Cameron

Subject: Re: [PATCH] IIO: adc: xilinx-xadc-core.c: constify iio_buffer_setup_ops structure

On 15 November 2015 23:11:51 GMT+00:00, Nizam Haider <[email protected]> wrote:
>structure iio_buffer_setup_ops is never modified, so declare it as
>const.
>
>Signed-off-by: Nizam Haider <[email protected]>
Sometimes it feels like there is something in the air...

Julia Lawal posted a patch for this yesterday.

Thanks

Jonathan
>---
> drivers/iio/adc/xilinx-xadc-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/iio/adc/xilinx-xadc-core.c
>b/drivers/iio/adc/xilinx-xadc-core.c
>index 0370624..c2b5f10 100644
>--- a/drivers/iio/adc/xilinx-xadc-core.c
>+++ b/drivers/iio/adc/xilinx-xadc-core.c
>@@ -803,7 +803,7 @@ err:
> return ret;
> }
>
>-static struct iio_buffer_setup_ops xadc_buffer_ops = {
>+static const struct iio_buffer_setup_ops xadc_buffer_ops = {
> .preenable = &xadc_preenable,
> .postenable = &iio_triggered_buffer_postenable,
> .predisable = &iio_triggered_buffer_predisable,

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.