2015-11-16 00:06:31

by Nizam Haider

Subject: [PATCH] IIO: adc: at91_adc.c Prefer kmalloc_array over kmalloc with multiply

So this patch swaps that use out for kmalloc_array instead.

Signed-off-by Nizam Haider <[email protected]>
---
drivers/iio/adc/at91_adc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
index 7b40925..f284cd6 100644
--- a/drivers/iio/adc/at91_adc.c
+++ b/drivers/iio/adc/at91_adc.c
@@ -742,7 +742,7 @@ static int at91_adc_of_get_resolution(struct at91_adc_state *st,
return count;
}

- resolutions = kmalloc(count * sizeof(*resolutions), GFP_KERNEL);
+ resolutions = kmalloc_array(count, sizeof(*resolutions), GFP_KERNEL);
if (!resolutions)
return -ENOMEM;

--
1.8.1.4

2015-11-22 12:06:46

by Jonathan Cameron

Subject: Re: [PATCH] IIO: adc: at91_adc.c Prefer kmalloc_array over kmalloc with multiply

On 16/11/15 00:05, Nizam Haider wrote:
> So this patch swaps that use out for kmalloc_array instead.
>
> Signed-off-by Nizam Haider <[email protected]>
Applied to the togreg branch of iio.git - initially push out as staging
Thanks,

Jonathan
> ---
> drivers/iio/adc/at91_adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index 7b40925..f284cd6 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -742,7 +742,7 @@ static int at91_adc_of_get_resolution(struct at91_adc_state *st,
> return count;
> }
>
> - resolutions = kmalloc(count * sizeof(*resolutions), GFP_KERNEL);
> + resolutions = kmalloc_array(count, sizeof(*resolutions), GFP_KERNEL);
> if (!resolutions)
> return -ENOMEM;
>
>