Hello
Change since v3
- Added reviewed-by and tested-by
- Fix Capital letter and missing dot in the comment.
Changes since v2
- removed err variable
- fix a spelling issue
Changes since v1
- drop the return code of kstrtou8 and return -EPROTO
as suggested by Jean Delvare
- Added a comment on the return code drop
Regards
LABBE Corentin (1):
i2c: taos-evm: replace simple_strtoul by kstrtou8
drivers/i2c/busses/i2c-taos-evm.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
--
2.4.10
The simple_strtoul function is marked as obsolete.
This patch replace it by kstrtou8.
Reviewed-by: Jean Delvare <[email protected]>
Tested-by: Jean Delvare <[email protected]>
Signed-off-by: LABBE Corentin <[email protected]>
---
drivers/i2c/busses/i2c-taos-evm.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c
index 4c7fc2d..210ca82 100644
--- a/drivers/i2c/busses/i2c-taos-evm.c
+++ b/drivers/i2c/busses/i2c-taos-evm.c
@@ -130,7 +130,13 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr,
return 0;
} else {
if (p[0] == 'x') {
- data->byte = simple_strtol(p + 1, NULL, 16);
+ /*
+ * Voluntarily dropping error code of kstrtou8 since all
+ * error code that it could return are invalid according
+ * to Documentation/i2c/fault-codes.
+ */
+ if (kstrtou8(p + 1, 16, &data->byte))
+ return -EPROTO;
return 0;
}
}
--
2.4.10
On Tue, Nov 24, 2015 at 08:43:27AM +0100, LABBE Corentin wrote:
> The simple_strtoul function is marked as obsolete.
> This patch replace it by kstrtou8.
>
> Reviewed-by: Jean Delvare <[email protected]>
> Tested-by: Jean Delvare <[email protected]>
> Signed-off-by: LABBE Corentin <[email protected]>
Applied to for-next, thanks!