2015-11-25 11:36:08

by Ching Huang

Subject: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

From: Ching Huang <[email protected]>

Fixed getting wrong configuration data of adapter type B and type D.

Signed-of-by: Ching Huang <[email protected]>

---

diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
--- a/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-23 16:25:22.000000000 +0800
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-24 11:35:26.000000000 +0800
@@ -2694,15 +2694,15 @@ static bool arcmsr_hbaB_get_config(struc
acb->firm_model,
acb->firm_version);

- acb->signature = readl(&reg->message_rwbuffer[1]);
+ acb->signature = readl(&reg->message_rwbuffer[0]);
/*firm_signature,1,00-03*/
- acb->firm_request_len = readl(&reg->message_rwbuffer[2]);
+ acb->firm_request_len = readl(&reg->message_rwbuffer[1]);
/*firm_request_len,1,04-07*/
- acb->firm_numbers_queue = readl(&reg->message_rwbuffer[3]);
+ acb->firm_numbers_queue = readl(&reg->message_rwbuffer[2]);
/*firm_numbers_queue,2,08-11*/
- acb->firm_sdram_size = readl(&reg->message_rwbuffer[4]);
+ acb->firm_sdram_size = readl(&reg->message_rwbuffer[3]);
/*firm_sdram_size,3,12-15*/
- acb->firm_hd_channels = readl(&reg->message_rwbuffer[5]);
+ acb->firm_hd_channels = readl(&reg->message_rwbuffer[4]);
/*firm_ide_channels,4,16-19*/
acb->firm_cfg_version = readl(&reg->message_rwbuffer[25]); /*firm_cfg_version,25,100-103*/
/*firm_ide_channels,4,16-19*/
@@ -2880,15 +2880,15 @@ static bool arcmsr_hbaD_get_config(struc
iop_device_map++;
count--;
}
- acb->signature = readl(&reg->msgcode_rwbuffer[1]);
+ acb->signature = readl(&reg->msgcode_rwbuffer[0]);
/*firm_signature,1,00-03*/
- acb->firm_request_len = readl(&reg->msgcode_rwbuffer[2]);
+ acb->firm_request_len = readl(&reg->msgcode_rwbuffer[1]);
/*firm_request_len,1,04-07*/
- acb->firm_numbers_queue = readl(&reg->msgcode_rwbuffer[3]);
+ acb->firm_numbers_queue = readl(&reg->msgcode_rwbuffer[2]);
/*firm_numbers_queue,2,08-11*/
- acb->firm_sdram_size = readl(&reg->msgcode_rwbuffer[4]);
+ acb->firm_sdram_size = readl(&reg->msgcode_rwbuffer[3]);
/*firm_sdram_size,3,12-15*/
- acb->firm_hd_channels = readl(&reg->msgcode_rwbuffer[5]);
+ acb->firm_hd_channels = readl(&reg->msgcode_rwbuffer[4]);
/*firm_hd_channels,4,16-19*/
acb->firm_cfg_version = readl(&reg->msgcode_rwbuffer[25]);
pr_notice("Areca RAID Controller%d: Model %s, F/W %s\n",

2015-11-25 11:59:29

by Johannes Thumshirn

Subject: Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

On Wed, 2015-11-25 at 19:36 +0800, Ching Huang wrote:
> From: Ching Huang <[email protected]>
>
> Fixed getting wrong configuration data of adapter type B and type D.
>
> Signed-of-by: Ching Huang <[email protected]>
>
> ---
>
> diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c
> b/drivers/scsi/arcmsr/arcmsr_hba.c
> --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-23 16:25:22.000000000
> +0800
> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-24 11:35:26.000000000
> +0800
> @@ -2694,15 +2694,15 @@ static bool arcmsr_hbaB_get_config(struc
>   acb->firm_model,
>   acb->firm_version);
>  
> - acb->signature = readl(&reg->message_rwbuffer[1]);
> + acb->signature = readl(&reg->message_rwbuffer[0]);
>   /*firm_signature,1,00-03*/
> - acb->firm_request_len = readl(&reg->message_rwbuffer[2]);
> + acb->firm_request_len = readl(&reg->message_rwbuffer[1]);
>   /*firm_request_len,1,04-07*/
> - acb->firm_numbers_queue = readl(&reg->message_rwbuffer[3]);
> + acb->firm_numbers_queue = readl(&reg->message_rwbuffer[2]);
>   /*firm_numbers_queue,2,08-11*/
> - acb->firm_sdram_size = readl(&reg->message_rwbuffer[4]);
> + acb->firm_sdram_size = readl(&reg->message_rwbuffer[3]);
>   /*firm_sdram_size,3,12-15*/
> - acb->firm_hd_channels = readl(&reg->message_rwbuffer[5]);
> + acb->firm_hd_channels = readl(&reg->message_rwbuffer[4]);
>   /*firm_ide_channels,4,16-19*/
>   acb->firm_cfg_version = readl(&reg-
> >message_rwbuffer[25]);  /*firm_cfg_version,25,100-103*/
>   /*firm_ide_channels,4,16-19*/
> @@ -2880,15 +2880,15 @@ static bool arcmsr_hbaD_get_config(struc
>   iop_device_map++;
>   count--;
>   }
> - acb->signature = readl(&reg->msgcode_rwbuffer[1]);
> + acb->signature = readl(&reg->msgcode_rwbuffer[0]);
>   /*firm_signature,1,00-03*/
> - acb->firm_request_len = readl(&reg->msgcode_rwbuffer[2]);
> + acb->firm_request_len = readl(&reg->msgcode_rwbuffer[1]);
>   /*firm_request_len,1,04-07*/
> - acb->firm_numbers_queue = readl(&reg->msgcode_rwbuffer[3]);
> + acb->firm_numbers_queue = readl(&reg->msgcode_rwbuffer[2]);
>   /*firm_numbers_queue,2,08-11*/
> - acb->firm_sdram_size = readl(&reg->msgcode_rwbuffer[4]);
> + acb->firm_sdram_size = readl(&reg->msgcode_rwbuffer[3]);
>   /*firm_sdram_size,3,12-15*/
> - acb->firm_hd_channels = readl(&reg->msgcode_rwbuffer[5]);
> + acb->firm_hd_channels = readl(&reg->msgcode_rwbuffer[4]);
>   /*firm_hd_channels,4,16-19*/
>   acb->firm_cfg_version = readl(&reg->msgcode_rwbuffer[25]);
>   pr_notice("Areca RAID Controller%d: Model %s, F/W %s\n",
>
>

Reviewed-by: Johannes Thumshirn <[email protected]>

2015-11-25 12:05:03

by Hannes Reinecke

Subject: Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

On 11/25/2015 12:36 PM, Ching Huang wrote:
> From: Ching Huang <[email protected]>
>
> Fixed getting wrong configuration data of adapter type B and type D.
>
> Signed-of-by: Ching Huang <[email protected]>
>
> ---
>
Reviewed-by: Hannes Reinecke <[email protected]>

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
[email protected] +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

2015-12-01 00:18:34

by Martin K. Petersen

Subject: Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

>>>>> "Ching" == Ching Huang <[email protected]> writes:

Hello Ching,

I applied both your series to 4.5/scsi-queue.

In the future please run checkpatch before submitting. Warnings are OK
but in this case there were several things flagged as errors that I had
to fix up by hand.

Also make sure you tag with "Signed-off-by:". Your signoff was mistyped
in all the patches.

Thank you!
Martin

--
Martin K. Petersen Oracle Linux Engineering

2015-12-01 02:52:10

by Ching Huang

Subject: Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

On Mon, 2015-11-30 at 19:17 -0500, Martin K. Petersen wrote:
> >>>>> "Ching" == Ching Huang <[email protected]> writes:
>
> Hello Ching,
>
> I applied both your series to 4.5/scsi-queue.
>
> In the future please run checkpatch before submitting. Warnings are OK
> but in this case there were several things flagged as errors that I had
> to fix up by hand.
>
> Also make sure you tag with "Signed-off-by:". Your signoff was mistyped
> in all the patches.
>
> Thank you!
> Martin
>
Thanks Martin's effort and advice.
I will pay attention on future submitting.

Best Regards,
Ching