2015-12-02 20:42:18

by Geyslan G. Bem

Subject: [PATCH 1/3] usb: uhci: replace dma_pool_alloc and memset with dma_pool_zalloc

Replace dma_pool_alloc and memset with a single call to dma_pool_zalloc.

Caught by coccinelle.

Signed-off-by: Geyslan G. Bem <[email protected]>
---
drivers/usb/host/uhci-q.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/host/uhci-q.c b/drivers/usb/host/uhci-q.c
index da6f56d..c17ea15 100644
--- a/drivers/usb/host/uhci-q.c
+++ b/drivers/usb/host/uhci-q.c
@@ -248,11 +248,10 @@ static struct uhci_qh *uhci_alloc_qh(struct uhci_hcd *uhci,
dma_addr_t dma_handle;
struct uhci_qh *qh;

- qh = dma_pool_alloc(uhci->qh_pool, GFP_ATOMIC, &dma_handle);
+ qh = dma_pool_zalloc(uhci->qh_pool, GFP_ATOMIC, &dma_handle);
if (!qh)
return NULL;

- memset(qh, 0, sizeof(*qh));
qh->dma_handle = dma_handle;

qh->element = UHCI_PTR_TERM(uhci);
--
2.6.2

2015-12-04 16:25:27

by Greg Kroah-Hartman

Subject: Re: [PATCH 1/3] usb: uhci: replace dma_pool_alloc and memset with dma_pool_zalloc

On Wed, Dec 02, 2015 at 05:41:44PM -0300, Geyslan G. Bem wrote:
> Replace dma_pool_alloc and memset with a single call to dma_pool_zalloc.
>
> Caught by coccinelle.
>
> Signed-off-by: Geyslan G. Bem <[email protected]>
> ---
> drivers/usb/host/uhci-q.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

This is already in my tree, it was done by someone else before you,
sorry about that :(

greg k-h