2015-12-05 10:10:38

by Tomer Barletz

Subject: [PATCH] netfilter: Initialize local variables to NULL, to prevent using them when uninitialized.

Signed-off-by: Tomer Barletz <[email protected]>
---
net/netfilter/nfnetlink_queue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c
index 7d81d28..e8be660 100644
--- a/net/netfilter/nfnetlink_queue.c
+++ b/net/netfilter/nfnetlink_queue.c
@@ -313,7 +313,7 @@ nfqnl_build_packet_message(struct net *net, struct nfqnl_instance *queue,
struct net_device *outdev;
struct nf_conn *ct = NULL;
enum ip_conntrack_info uninitialized_var(ctinfo);
- struct nfnl_ct_hook *nfnl_ct;
+ struct nfnl_ct_hook *nfnl_ct = NULL;
bool csum_verify;
char *secdata = NULL;
u32 seclen = 0;
@@ -1041,7 +1041,7 @@ nfqnl_recv_verdict(struct sock *ctnl, struct sk_buff *skb,
unsigned int verdict;
struct nf_queue_entry *entry;
enum ip_conntrack_info uninitialized_var(ctinfo);
- struct nfnl_ct_hook *nfnl_ct;
+ struct nfnl_ct_hook *nfnl_ct = NULL;
struct nf_conn *ct = NULL;

struct net *net = sock_net(ctnl);
--
2.5.0

2015-12-09 13:51:04

by Pablo Neira Ayuso

Subject: Re: [PATCH] netfilter: Initialize local variables to NULL, to prevent using them when uninitialized.

We already have this:

http://git.kernel.org/cgit/linux/kernel/git/pablo/nf.git/commit/?id=8e662164abb4a8fde701a46e1431980f9e325742

We'll be sending this today to David to avoid this annoyance.

Thanks for you patch anyway.