2015-12-07 09:09:15

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] ethernet: aurora: AURORA_NB8800 should depend on HAS_DMA

If NO_DMA=y:

ERROR: "dma_map_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
ERROR: "dma_unmap_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
ERROR: "dma_unmap_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
ERROR: "dma_mapping_error" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
ERROR: "dma_map_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
ERROR: "dma_free_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/net/ethernet/aurora/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/aurora/Kconfig b/drivers/net/ethernet/aurora/Kconfig
index a3c7106fdf85e78f..8ba7f8ff3434000f 100644
--- a/drivers/net/ethernet/aurora/Kconfig
+++ b/drivers/net/ethernet/aurora/Kconfig
@@ -13,6 +13,7 @@ if NET_VENDOR_AURORA

config AURORA_NB8800
tristate "Aurora AU-NB8800 support"
+ depends on HAS_DMA
select PHYLIB
help
Support for the AU-NB8800 gigabit Ethernet controller.
--
1.9.1


2015-12-07 11:12:27

by Måns Rullgård

[permalink] [raw]
Subject: Re: [PATCH] ethernet: aurora: AURORA_NB8800 should depend on HAS_DMA

Geert Uytterhoeven <[email protected]> writes:

> If NO_DMA=y:
>
> ERROR: "dma_map_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_unmap_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_unmap_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_alloc_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_mapping_error" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_map_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_free_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Acked-by: Mans Rullgard <[email protected]>

> drivers/net/ethernet/aurora/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/aurora/Kconfig b/drivers/net/ethernet/aurora/Kconfig
> index a3c7106fdf85e78f..8ba7f8ff3434000f 100644
> --- a/drivers/net/ethernet/aurora/Kconfig
> +++ b/drivers/net/ethernet/aurora/Kconfig
> @@ -13,6 +13,7 @@ if NET_VENDOR_AURORA
>
> config AURORA_NB8800
> tristate "Aurora AU-NB8800 support"
> + depends on HAS_DMA
> select PHYLIB
> help
> Support for the AU-NB8800 gigabit Ethernet controller.
> --
> 1.9.1
>

--
M?ns Rullg?rd
[email protected]

2015-12-07 18:55:32

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] ethernet: aurora: AURORA_NB8800 should depend on HAS_DMA

From: Geert Uytterhoeven <[email protected]>
Date: Mon, 7 Dec 2015 10:09:06 +0100

> If NO_DMA=y:
>
> ERROR: "dma_map_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_unmap_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_unmap_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_alloc_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_mapping_error" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_map_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_free_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Applied, thanks Geert.