2015-12-08 17:46:40

by Anshul Garg

Subject: [PATCH] iio/inkern.c Use list_for_each_entry_safe

Use list_for_each_entry_safe instead of list_for_each_safe
and list_entry call.

Signed-off-by: Anshul Garg <[email protected]>
---
drivers/iio/inkern.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
index c8bad3c..f764eb6 100644
--- a/drivers/iio/inkern.c
+++ b/drivers/iio/inkern.c
@@ -61,12 +61,10 @@ EXPORT_SYMBOL_GPL(iio_map_array_register);
int iio_map_array_unregister(struct iio_dev *indio_dev)
{
int ret = -ENODEV;
- struct iio_map_internal *mapi;
- struct list_head *pos, *tmp;
+ struct iio_map_internal *mapi, *next;

mutex_lock(&iio_map_list_lock);
- list_for_each_safe(pos, tmp, &iio_map_list) {
- mapi = list_entry(pos, struct iio_map_internal, l);
+ list_for_each_entry_safe(mapi, next, &iio_map_list, l) {
if (indio_dev == mapi->indio_dev) {
list_del(&mapi->l);
kfree(mapi);
--
1.7.9.5


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

2015-12-12 17:23:50

by Jonathan Cameron

Subject: Re: [PATCH] iio/inkern.c Use list_for_each_entry_safe

On 08/12/15 17:45, Anshul Garg wrote:
> Use list_for_each_entry_safe instead of list_for_each_safe
> and list_entry call.
>
> Signed-off-by: Anshul Garg <[email protected]>
Applied to the togreg branch of iio.git - initially pushed out
as testing for the autobuilder to play with it.

Thanks,

Jonathan
> ---
> drivers/iio/inkern.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index c8bad3c..f764eb6 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -61,12 +61,10 @@ EXPORT_SYMBOL_GPL(iio_map_array_register);
> int iio_map_array_unregister(struct iio_dev *indio_dev)
> {
> int ret = -ENODEV;
> - struct iio_map_internal *mapi;
> - struct list_head *pos, *tmp;
> + struct iio_map_internal *mapi, *next;
>
> mutex_lock(&iio_map_list_lock);
> - list_for_each_safe(pos, tmp, &iio_map_list) {
> - mapi = list_entry(pos, struct iio_map_internal, l);
> + list_for_each_entry_safe(mapi, next, &iio_map_list, l) {
> if (indio_dev == mapi->indio_dev) {
> list_del(&mapi->l);
> kfree(mapi);
>